Skip to content

Commit

Permalink
Clean up code comments
Browse files Browse the repository at this point in the history
  • Loading branch information
helhum committed Jul 3, 2016
1 parent be30dac commit 91b184a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
10 changes: 5 additions & 5 deletions src/Installer/ExtensionInstaller.php
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public function install(InstalledRepositoryInterface $repo, PackageInterface $pa
$this->binaryInstaller->removeBinaries($package);
}
$this->installCode($package);
$this->binaryInstaller->installBinaries($package, $this->getInstallPath($package));
$this->binaryInstaller->installBinaries($package, $downloadPath);
if (!$repo->hasPackage($package)) {
$repo->addPackage(clone $package);
}
Expand Down Expand Up @@ -157,9 +157,9 @@ public function update(InstalledRepositoryInterface $repo, PackageInterface $ini
* Uninstalls specific package.
*
* @param InstalledRepositoryInterface $repo repository in which to check
* @param PackageInterface $package package instance
* @param PackageInterface $package
*
* @throws \InvalidArgumentException if $initial package is not installed
* @throws \InvalidArgumentException if $package is not installed
*/
public function uninstall(InstalledRepositoryInterface $repo, PackageInterface $package)
{
Expand All @@ -175,8 +175,8 @@ public function uninstall(InstalledRepositoryInterface $repo, PackageInterface $
/**
* Returns the installation path of a package
*
* @param PackageInterface $package
* @return string path
* @param PackageInterface $package
* @return string path
*/
public function getInstallPath(PackageInterface $package)
{
Expand Down
3 changes: 1 addition & 2 deletions src/Plugin/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ public function merge(array $config)
*
* @param string $key
* @param int $flags Options (see class constants)
* @throws \RuntimeException
* @return mixed
*/
public function get($key, $flags = 0)
Expand All @@ -93,7 +92,7 @@ public function get($key, $flags = 0)
case 'cache-dir':
case 'cms-package-dir':
$val = rtrim($this->process($this->config[$key], $flags), '/\\');
return ($flags & self::RELATIVE_PATHS == 1) ? $val : $this->realpath($val);
return ($flags & self::RELATIVE_PATHS === 1) ? $val : $this->realpath($val);
default:
if (!isset($this->config[$key])) {
return null;
Expand Down

0 comments on commit 91b184a

Please sign in to comment.