[BUGFIX] Support division by floats smaller than 1 #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And I guess this fixes #670 ? |
sbuerk
force-pushed
the
bugfix/floatDivision
branch
from
cdf0b97
to
3e5eac6
Compare
|
I added some edge cases that worked before (e. g. empty string, which results in |
ohader
reviewed
Jun 13, 2023
s2b
force-pushed
the
bugfix/floatDivision
branch
from
144c0e1
to
b4fab77
Compare
Previously, divisions by a float smaller than 1 in Fluid inline syntax always resulted in 0. This change adjusts MathExpressionNode to differentiate between floats and integers correctly. Resolves: TYPO3#670 Resolves: https://forge.typo3.org/issues/99214
sbuerk
force-pushed
the
bugfix/floatDivision
branch
from
ad237b7
to
39d7edf
Compare
tlueder
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, divisions by a float smaller than 1 in Fluid inline syntax
always resulted in 0. This change adjusts MathExpressionNode
to differentiate between floats and integers correctly.
Resolves: #670
Resolves: https://forge.typo3.org/issues/99214