Normalize category storage PID on TYPO3v12 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch solves the issue for the CategoryRepository, however we have the same issue in the PostRepository |
|
Attached patch also solves this for the PostRepository |
The new TypoScript parser introduced in TYPO3v12 yields a regular integer in case of a single storagePid. Only in case of a CSV this will be a string. This in turn leads to explode() failing with a type error in the integer case. Fix this by normalizing the setting value to string. Fixes: TYPO3GmbH#301
|
Thanks, I've refreshed the PR, included your change and also did the same for the |
|
@mbrodala your solution would still fail if the setting contained a non-scalar value like an array. It would be safer to test if it is set to a scalar value as I did in my patch, first. |
|
That is something left to do in case TYPO3 ever supports this. Right now it can only be a string, the implicit conversion to a number could be considered a unintended side-effect. Do you have an example where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new TypoScript parser introduced in TYPO3v12 yields a regular integer in case of a single storagePid. Only in case of a CSV this will be a string. This in turn leads to explode() failing with a type error in the integer case.
Fix this by normalizing the setting value to string.
Fixes: #301