Skip to content

Conversation

@ZHallen122
Copy link
Collaborator

Summary

This PR refines the i18next ESLint configuration for the vscode-webui package to significantly reduce false positives while maintaining effective internationalization coverage:

  • Changed mode from jsx-text-only to jsx-only to enable targeted attribute checking
  • Added jsx-attributes whitelist to only check user-facing attributes (title, alt, placeholder, label)
  • Excluded all function call arguments from validation to reduce noise from technical/developer strings
  • Added single letter exclusion pattern for initials
  • Added brand name exclusion for "Pochi"

These changes focus the linting on actual user-facing text that needs translation, while ignoring technical attributes like className, variant, size, and developer-oriented function arguments.

Test plan

  • All existing tests pass
  • ESLint configuration follows the i18next/no-literal-string plugin's documented options
  • Changes reduce false positives without compromising i18n coverage of user-facing text

🤖 Generated with Pochi

@ZHallen122 ZHallen122 marked this pull request as draft October 31, 2025 21:17
@ZHallen122 ZHallen122 requested a review from wsxiaoys October 31, 2025 21:20
@wsxiaoys wsxiaoys requested a review from liangfung November 1, 2025 02:18
@wsxiaoys wsxiaoys marked this pull request as ready for review November 3, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants