Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support self-signed cert in smtp #2952

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: support self-signed cert in smtp #2952

wants to merge 3 commits into from

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Aug 22, 2024 •
edited
Loading

hold for #3035

@zwpaper zwpaper changed the title feat: smpt shpport self-signed cert feat: smtp shpport self-signed cert Aug 22, 2024
@zwpaper zwpaper force-pushed the feat/self-signed-email branch from 555da03 to 8ffed6f Compare August 22, 2024 17:05
wsxiaoys
wsxiaoys requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split the PR into two pieces:
1st: One with environment variable override.
2nd: on top of 1st, adding support to load pem from frontend.

We shall be ale to merge 1st once tested, and will leave 2nd merging when frontend integration is done.

@wsxiaoys wsxiaoys changed the title feat: smtp shpport self-signed cert feat: support self-signed cert in smtp Aug 30, 2024
@zwpaper zwpaper mentioned this pull request Sep 1, 2024
Merged
@zwpaper
Copy link
Member Author

zwpaper commented Sep 1, 2024

reading cert path from env PR is created #3035, this PR will remain open and I will update the db logic here after #3035 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsxiaoys wsxiaoys wsxiaoys requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwpaper @wsxiaoys