-
-
Notifications
You must be signed in to change notification settings - Fork 420
feat: add URL field type #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TrigamDev
wants to merge
13
commits into
TagStudioDev:main
Choose a base branch
from
TrigamDev:feat/url-field
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add URL field type #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be using this branch as my primary version of TagStudio for now, so I'll make sure to update here if I come across any issues. |
Appears that when copying fields, it only copies the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
URLfield type, which replaces URL detection in text fields.Closes #1140
Changes Made
Core
URL, which takes a URL title and URL value.url_fieldstable to store the new URL fields, having fields for the URL title and URL value.URLandSOURCEhave been changed to be of the field typeURL.104(in context of feat: add hidden tags #1139 bumping it to103).104:URLandSOURCEfields are changed from being of typeTEXT_LINEto being of typeURLURL(so the two changed above) will be moved over to theurl_fieldstable.None, and will account for havingNonevalues.QT
UrlWidgetthat extendsTextWidgetwhich accepts a URL title and URL value and displays an embedded link.EditUrlmodal, providing inputs for editing the title and value of a URL field.Mixed
PanelModals only returning a string, they can now return an arbitrary number of arguments of any type.None. This is because most (if not all) save callbacks had this return type, which kept causing warnings.get_content()method ofPanelModals can now return an arbitrary number of arguments of any type instead of just string.valuefield, now takeskwargs, with each key corresponding to a field in the field's table, and each value corresponding to the value being written.add_field_to_entryandupdate_entry_fieldcalls to account for this change.test_libraryandtest_update_entry_with_multiple_identical_fieldstests to account for this change.Tasks Completed