Skip to content

refactor: resource_manager.py #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: resource_manager.py #958

wants to merge 4 commits into from

Conversation

VasigaranAndAngel
Copy link
Collaborator

@VasigaranAndAngel VasigaranAndAngel commented Jun 12, 2025 •
edited
Loading

Summary

  • Type annotation fixes
  • Made ResourceManager singleton
  • Simplified how the data is loaded and cached

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Refactor Code that needs to be restructured or cleaned up Status: Review Needed A review of this is needed labels Jun 12, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Jun 12, 2025
Computerdores
Computerdores reviewed Jun 13, 2025
View reviewed changes
@Computerdores Computerdores moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Computerdores Computerdores Computerdores left review comments

Assignees
No one assigned
Labels
Status: Review Needed A review of this is needed Type: Refactor Code that needs to be restructured or cleaned up
Projects
TagStudio Development
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VasigaranAndAngel @Computerdores @CyanVoxel