Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder classes on top of function definitions #1420

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Reorder classes on top of function definitions #1420

merged 5 commits into from
Jan 29, 2025

Conversation

C0rn3j
Copy link
Collaborator

@C0rn3j C0rn3j commented Jan 27, 2025 •
edited
Loading

More bits from #1388:

  • Moves all class definitions to go before function definitions, pulling the two nested class definitions in the top codeblock. Class order was kept.
  • Fixes redundant bit of code in GuiVar, as the same code is already called from Prefs first where we get the var from
  • Fixes docstring in bootstrap file
  • Fix up Gtk.Settings typing
  • Fix up imports in Prefs that should have been in TYPING

@Taiko2k Taiko2k merged commit 34bb6a4 into Taiko2k:master Jan 29, 2025
3 of 4 checks passed
@C0rn3j C0rn3j deleted the class-improvs branch January 29, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rn3j @Taiko2k