Yyin/QTDI-653 add LastGroup annotation to Processor's afterGroup method. #966
+880
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undx
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Hello,
some comments below.
Why changing the sample-connector, it's not necessary. You can create UT elsewhere in project.
Concerning UT, I think that you should enforce tests on this feature.
- check backward compatibility
- check state when using lastgroup
- etc.
We also need to change validation for aftergroup. We should not be able to
handle both signatures and check for that.
I don't see why component-tools/src/test/resources/org/talend/test/valid/httpclient/Messages.properties
has some changes?
QueueOutput as some todo tasks that were used for debugging...
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
undx
reviewed
Dec 20, 2024
| @@ -26,4 +28,31 @@ public class AutoChunkProcessor extends org.talend.sdk.component.runtime.manager | |||
| public AutoChunkProcessor(final int chunkSize, final Processor processor) { | |||
There was a problem hiding this comment.
Please, create an UT to test theses changes. See UTs in this module.
|
Analysis Details1 Issue
Coverage and Duplications
Project ID: org.talend.sdk.component:component-runtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://qlik-dev.atlassian.net/browse/QTDI-653
Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?