Fix script-config-jest + remove not necessary mock in packages

Talend · Oct 20, 2023 · 08fb9f9 · 08fb9f9
1 parent 27f728b
commit 08fb9f9
Show file tree

Hide file tree

Showing 37 changed files with 82 additions and 161 deletions.
diff --git a/packages/components/src/DataViewer/Headers/TreeHeader/TreeHeader.test.js b/packages/components/src/DataViewer/Headers/TreeHeader/TreeHeader.test.js
@@ -2,13 +2,6 @@ import { render, screen } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import Component from './TreeHeader.component';
 
-jest.mock('react-i18next', () => {
-	// eslint-disable-next-line global-require
-	const mockTranslations = require('../../../../test/i18nMock').default;
-
-	return mockTranslations();
-});
-
 describe('TreeHeader', () => {
 	it('should render a simple tree header', () => {
 		const { container } = render(<Component title="myTitle" />);

diff --git a/packages/components/src/DataViewer/Icons/TreeBranchIcon/TreeBranchIcon.test.js b/packages/components/src/DataViewer/Icons/TreeBranchIcon/TreeBranchIcon.test.js
@@ -1,12 +1,7 @@
 import { render, screen } from '@testing-library/react';
 import Component, { getDefaultIcon } from './TreeBranchIcon.component';
-jest.unmock('@talend/design-system');
-jest.mock('react-i18next', () => {
-	// eslint-disable-next-line global-require
-	const mockTranslations = require('../../../../test/i18nMock').default;
 
-	return mockTranslations();
-});
+jest.unmock('@talend/design-system');
 
 describe('getDefaultIcon', () => {
 	it('should return a custom object icon', () => {

diff --git a/packages/components/test/i18nMock.js b/packages/components/test/i18nMock.js
diff --git a/packages/faceted-search/jest.setup.js b/packages/faceted-search/jest.setup.js
@@ -1,3 +1,2 @@
 // DS is mocked by ui-scripts, preventing us to use testing-library getByLabelText & others selectors
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
diff --git a/packages/faceted-search/package.json b/packages/faceted-search/package.json
@@ -61,7 +61,6 @@
     "@talend/scripts-config-storybook-lib": "^5.0.0",
     "@testing-library/react": "^12.1.5",
     "@testing-library/user-event": "^13.5.0",
-    "ally.js": "^1.4.1",
     "babel-plugin-angularjs-annotate": "^0.10.0",
     "cross-env": "^7.0.3",
     "i18next": "^20.6.1",

diff --git a/packages/faceted-search/src/components/Badges/BadgeTags/BadgeTags.component.test.js b/packages/faceted-search/src/components/Badges/BadgeTags/BadgeTags.component.test.js
@@ -4,8 +4,6 @@ import { render, screen, waitFor } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import getDefaultT from '../../../translate';
 
-jest.mock('ally.js');
-
 const badgeFacetedContextValue = {
 	dispatch: jest.fn(),
 };

diff --git a/packages/forms/src/UIForm/UIForm.container.test.js b/packages/forms/src/UIForm/UIForm.container.test.js
@@ -4,8 +4,6 @@ import userEvent from '@testing-library/user-event';
 import { actions, getMockData, getMockNestedData, initProps } from '../../__mocks__/data';
 import UIForm from './UIForm.container';
 
-jest.mock('ally.js');
-
 describe('UIForm container', () => {
 	let props;
 	beforeEach(() => {

diff --git a/packages/forms/src/UIForm/Widget/Widget.component.test.js b/packages/forms/src/UIForm/Widget/Widget.component.test.js
@@ -6,7 +6,6 @@ import { WidgetContext } from '../context';
 import Widget from './Widget.component';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 describe('Widget component', () => {
 	const schema = {

diff --git a/packages/forms/src/UIForm/fields/Button/SingleButton.component.test.js b/packages/forms/src/UIForm/fields/Button/SingleButton.component.test.js
@@ -3,7 +3,6 @@ import userEvent from '@testing-library/user-event';
 
 import SingleButton from './SingleButton.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 describe('SingleButton field', () => {

diff --git a/packages/forms/src/UIForm/fields/Code/Code.component.test.tsx b/packages/forms/src/UIForm/fields/Code/Code.component.test.tsx
@@ -9,9 +9,6 @@ import 'ace-builds/src-noconflict/ext-language_tools';
 
 import Code, { CodeProps } from './Code.component';
 
-// fix cannot read appendChild of null;
-jest.mock('ally.js');
-
 declare global {
 	interface Window {
 		ReactAce: { default: typeof ReactAce };

diff --git a/packages/forms/src/UIForm/fields/Datalist/Datalist.component.test.js b/packages/forms/src/UIForm/fields/Datalist/Datalist.component.test.js
@@ -4,7 +4,6 @@ import userEvent from '@testing-library/user-event';
 
 import Datalist from './Datalist.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 const schema = {

diff --git a/packages/forms/src/UIForm/fields/Datalist/displayMode/TextMode.component.test.js b/packages/forms/src/UIForm/fields/Datalist/displayMode/TextMode.component.test.js
@@ -1,7 +1,6 @@
 import { render, screen } from '@testing-library/react';
 import DatalistTextMode from './TextMode.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 const schema = {
 	title: 'My List',

diff --git a/packages/forms/src/UIForm/fields/Date/Date.component.test.js b/packages/forms/src/UIForm/fields/Date/Date.component.test.js
@@ -1,6 +1,6 @@
 import { act, render, screen, fireEvent } from '@testing-library/react';
 import DateWidget from './Date.component';
-jest.mock('ally.js');
+
 jest.unmock('@talend/design-system');
 
 describe('Date widget', () => {

diff --git a/packages/forms/src/UIForm/fields/Date/DateTime.component.test.js b/packages/forms/src/UIForm/fields/Date/DateTime.component.test.js
@@ -1,7 +1,6 @@
 import { act, render, screen, fireEvent } from '@testing-library/react';
 import DateTimeWidget from './DateTime.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 describe('DateTime widget', () => {

diff --git a/packages/forms/src/UIForm/fields/Date/Time.component.test.js b/packages/forms/src/UIForm/fields/Date/Time.component.test.js
@@ -2,7 +2,6 @@ import { act, render, screen, fireEvent } from '@testing-library/react';
 import TimeWidget from './Time.component';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 describe('Time component', () => {
 	beforeEach(() => {

diff --git a/packages/forms/src/UIForm/fields/Enumeration/EnumerationWidget.test.js b/packages/forms/src/UIForm/fields/Enumeration/EnumerationWidget.test.js
@@ -3,7 +3,6 @@ import userEvent from '@testing-library/user-event';
 import EnumerationWidget from './EnumerationWidget';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 describe('EnumerationWidget', () => {
 	it('should render items', () => {

diff --git a/packages/forms/src/UIForm/fields/FieldTemplate/FieldTemplate.component.test.js b/packages/forms/src/UIForm/fields/FieldTemplate/FieldTemplate.component.test.js
@@ -3,7 +3,6 @@ import { screen, render } from '@testing-library/react';
 import FieldTemplate from './FieldTemplate.component';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 describe('FieldTemplate', () => {
 	const defaultProps = {

diff --git a/packages/forms/src/UIForm/fields/File/File.component.test.js b/packages/forms/src/UIForm/fields/File/File.component.test.js
@@ -2,7 +2,6 @@ import { screen, render } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import File, { FileWidget, base64Decode } from './File.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 describe('File field', () => {

diff --git a/packages/forms/src/UIForm/fields/File/displayMode/TextMode.component.test.js b/packages/forms/src/UIForm/fields/File/displayMode/TextMode.component.test.js
@@ -1,6 +1,5 @@
 import { screen, render } from '@testing-library/react';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 import TextMode from './TextMode.component';

diff --git a/packages/forms/src/UIForm/fields/KeyValue/KeyValue.component.test.js b/packages/forms/src/UIForm/fields/KeyValue/KeyValue.component.test.js
@@ -3,7 +3,6 @@ import { screen, render } from '@testing-library/react';
 import { WidgetContext } from '../../context';
 import KeyValue from './KeyValue.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 const widgets = {

diff --git a/packages/forms/src/UIForm/fields/ListView/ListView.component.test.js b/packages/forms/src/UIForm/fields/ListView/ListView.component.test.js
@@ -4,7 +4,7 @@ import userEvent from '@testing-library/user-event';
 import ListView from './ListView.component';
 
 const NO_RESULT_MESSAGE = 'No results found';
-jest.mock('ally.js');
+
 jest.unmock('@talend/design-system');
 
 describe('ListView field', () => {

diff --git a/packages/forms/src/UIForm/fields/MultiSelectTag/MultiSelectTag.component.test.js b/packages/forms/src/UIForm/fields/MultiSelectTag/MultiSelectTag.component.test.js
@@ -3,7 +3,6 @@ import userEvent from '@testing-library/user-event';
 
 import MultiSelectTag from './MultiSelectTag.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 describe('MultiSelectTag field', () => {

diff --git a/packages/forms/src/UIForm/fields/RadioOrSelect/RadioOrSelect.component.test.js b/packages/forms/src/UIForm/fields/RadioOrSelect/RadioOrSelect.component.test.js
@@ -2,7 +2,6 @@ import { screen, render } from '@testing-library/react';
 
 import RadioOrSelect from './RadioOrSelect.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 describe('RadioOrSelect field', () => {

diff --git a/packages/forms/src/UIForm/fields/Radios/Radios.component.test.js b/packages/forms/src/UIForm/fields/Radios/Radios.component.test.js
@@ -2,7 +2,6 @@ import { screen, render, fireEvent } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import Radios from './Radios.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 describe('Radios field', () => {

diff --git a/packages/forms/src/UIForm/fields/ResourcePicker/ResourcePicker.component.test.js b/packages/forms/src/UIForm/fields/ResourcePicker/ResourcePicker.component.test.js
@@ -46,7 +46,6 @@ const ResourcePickerMock = ({ toolbar, onRowClick, isSelected, collection, ...pr
 	</div>
 );
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 jest.mock('@talend/react-components/lib/ResourcePicker', () => ResourcePickerMock);
 

diff --git a/packages/forms/src/UIForm/fields/Select/Select.component.test.js b/packages/forms/src/UIForm/fields/Select/Select.component.test.js
@@ -4,7 +4,6 @@ import omit from 'lodash/omit';
 
 import Select from './Select.component';
 
-jest.mock('ally.js');
 jest.unmock('@talend/design-system');
 
 describe('Select field', () => {

diff --git a/packages/forms/src/UIForm/fields/Toggle/Toggle.component.test.js b/packages/forms/src/UIForm/fields/Toggle/Toggle.component.test.js
@@ -3,7 +3,6 @@ import userEvent from '@testing-library/user-event';
 import Toggle from './Toggle.component';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 describe('Toggle field', () => {
 	const schema = {

diff --git a/packages/forms/src/UIForm/fieldsets/Array/Array.component.test.js b/packages/forms/src/UIForm/fieldsets/Array/Array.component.test.js
@@ -7,7 +7,6 @@ import { screen, render } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 function TestArray(props) {
 	return <div data-testid="array" data-props={JSON.stringify(props, null, 2)} />;

diff --git a/packages/forms/src/UIForm/fieldsets/Array/ArrayItem.component.test.js b/packages/forms/src/UIForm/fieldsets/Array/ArrayItem.component.test.js
@@ -4,7 +4,6 @@ import userEvent from '@testing-library/user-event';
 import ArrayItem from './ArrayItem.component';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 describe('Array Item component', () => {
 	it('should render control panel with item content', () => {

diff --git a/packages/forms/src/UIForm/fieldsets/Array/DefaultArrayTemplate.component.test.js b/packages/forms/src/UIForm/fieldsets/Array/DefaultArrayTemplate.component.test.js
@@ -2,7 +2,6 @@ import { screen, render } from '@testing-library/react';
 import DefaultArrayTemplate from './DefaultArrayTemplate.component';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 const schema = {
 	description: 'Tnstructions to fill it',

diff --git a/...ages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.test.js b/...ages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.test.js
@@ -7,7 +7,6 @@ import { WidgetContext } from '../../context';
 import widgets from '../../utils/widgets';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 function customTitle(value, schema) {
 	return `${schema.title}: ${value.firstname} ${value.lastname}`;

diff --git a/packages/forms/src/rhf/fields/Input/Input.test.js b/packages/forms/src/rhf/fields/Input/Input.test.js
@@ -5,7 +5,6 @@ import { useForm, FormProvider } from 'react-hook-form';
 import Input from './RHFInput.component';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 /* eslint-disable-next-line react/prop-types */
 function FormWrapper({ children, onSubmit }) {

diff --git a/packages/forms/src/rhf/fields/Select/Select.test.js b/packages/forms/src/rhf/fields/Select/Select.test.js
@@ -5,7 +5,6 @@ import { useForm, FormProvider } from 'react-hook-form';
 import Select from './RHFSelect.component';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 /* eslint-disable-next-line react/prop-types */
 function FormWrapper({ children, onSubmit }) {

diff --git a/packages/forms/src/rhf/fields/TextArea/RHFTextArea.test.js b/packages/forms/src/rhf/fields/TextArea/RHFTextArea.test.js
@@ -5,7 +5,6 @@ import { useForm, FormProvider } from 'react-hook-form';
 import TextArea from './RHFTextArea.component';
 
 jest.unmock('@talend/design-system');
-jest.mock('ally.js');
 
 /* eslint-disable-next-line react/prop-types */
 function FormWrapper({ children, onSubmit }) {
-Original file line number
+Diff line change
@@ Expand Up @@
     	</div>
     );
-    jest.mock('ally.js');
     jest.unmock('@talend/design-system');
     jest.mock('@talend/react-components/lib/ResourcePicker', () => ResourcePickerMock);
@@ Expand Down @@