Skip to content

Commit

Permalink
fix issue with dynamic-cdn-webpack-plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
smouillour committed Oct 17, 2023
1 parent bd452e0 commit 97f8232
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 8 deletions.
7 changes: 3 additions & 4 deletions .github/actions/setup-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ secrets:
runs:
using: 'composite'
steps:
- uses: pnpm/action-setup@v2
with:
version: 8

- name: Set up Node.js
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d #v3.8.1
with:
Expand All @@ -19,6 +15,9 @@ runs:
scope: '@talend'
cache: 'pnpm'

- name: Install PNPM
run: npm install -g [email protected]

- name: Get pnpm cache directory path
id: pnpm-cache-dir-path
shell: bash
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr-playground.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ jobs:
- name: Checkout sources
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac #v4.0.0

- name: Use Node.js
uses: ./.github/actions/setup-node

- name: Check UMD files size diff
uses: preactjs/compressed-size-action@8119d3d31b6e57b167e09c81dfa877eada3bcb35 #v2.5.0
if: github.ref != 'refs/heads/master'
Expand Down
4 changes: 3 additions & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
nodejs 20.8.0
nodejs 20.8.1
# asdf plugin-add pnpm
pnpm 8.9.2
1 change: 0 additions & 1 deletion fork/dynamic-cdn-webpack-plugin/src/find.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ describe('findPackages', () => {
const result = findPackages(undefined, 'react');

// then
console.log('LIST OF RESULT: ', result);
expect(result.length).toBe(2);
expect(result[0]).toBe('/node_modules/react');
expect(result[1]).toBe('/node_modules/@talend/react-components/node_modules/react');
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
"webpack": "^5.73.0"
},
"scripts": {
"postinstall": "pnpm --sort -r --stream run build:lib",
"postinstall": "pnpm -r --stream run build:lib",
"pre-release": "pnpm -r run pre-release",
"start": "pnpm --filter @talend/ui-playground run start",
"start-storybook": "pnpm --filter @talend/ui-storybook-one run start",
"release": "pnpm run pre-release && pnpm changeset publish",
"lint-staged": "lint-staged",
"lint": "pnpm -r --no-bail run lint",
"lint-merge-report": "pnpm -r lint-merge-report",
"test": "cross-env TZ=Europe/Paris pnpm -r --no-bail run test",
"test": "cross-env TZ=Europe/Paris pnpm -r --no-bail run test --silent",
"test:update": "cross-env TZ=Europe/Paris pnpm -r --no-bail run test --silent -u",
"test:cov": "cross-env TZ=Europe/Paris pnpm -r --no-bail run test:cov",
"test:demo": "pnpm -r --no-bail run test:demo",
Expand Down

0 comments on commit 97f8232

Please sign in to comment.