chore(TDP-12538): always show tooltip on faceted badge overlay

Talend · Sep 22, 2023 · b660447 · b660447
1 parent 9435bbc
commit b660447
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/.changeset/dirty-geckos-eat.md b/.changeset/dirty-geckos-eat.md
@@ -0,0 +1,5 @@
+---
+'@talend/react-faceted-search': minor
+---
+
+chore(TDP-12538): always show tooltip on faceted badge overlay
diff --git a/packages/faceted-search/src/components/Badges/BadgeOverlay/BadgeOverlay.component.js b/packages/faceted-search/src/components/Badges/BadgeOverlay/BadgeOverlay.component.js
@@ -88,17 +88,11 @@ const BadgeOverlay = ({
 		</Button>
 	);
 
-	const buttonToRender = iconName ? (
-		<TooltipTrigger label={label} tooltipPlacement="top">
-			{button}
-		</TooltipTrigger>
-	) : (
-		button
-	);
-
 	return (
 		<div className={className}>
-			{buttonToRender}
+			<TooltipTrigger label={label} tooltipPlacement="top">
+				{button}
+			</TooltipTrigger>
 
 			<Overlay
 				id={`${id}-overlay`}

diff --git a/...arch/src/components/Badges/BadgeOverlay/__snapshots__/BadgeOverlay.component.test.js.snap b/...arch/src/components/Badges/BadgeOverlay/__snapshots__/BadgeOverlay.component.test.js.snap
@@ -3,6 +3,7 @@
 exports[`BadgeOverlay should render the html output in the default state 1`] = `
 <div>
   <button
+    aria-describedby="42"
     aria-label="my label"
     class="btn btn-link"
     id="my-id-action-overlay"