feat(TDOPS-5220): add Talend Qlik white and dark logos #4913

inna-i · 2023-09-29T07:00:16Z

What is the problem this PR is trying to solve?
TDOPS-5220: Talend Logo in Trial updates

What is the chosen solution to this problem?

added white Talend Qlik logo
added dark Talend Qlik logo

Please check if the PR fulfills these requirements

The PR has used yarn changeset to request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes/features) And non reg done before need review
Docs have been added/updated (for bug fixes/features)
Related design/discussions / pages (not in Jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

aamalric-talend

LGTM

…-logos

…com:Talend/ui into innai/feat/TDOPS-5220/add-talend-qlik-logos

github-actions · 2023-09-29T07:42:33Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.17% (1268/1422)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	89.95% (5609/6235)	81.02% (3212/3964)	86.88% (1418/1632)
containers	83.53% (1385/1658)	74.67% (687/920)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
faceted-search	85.03% (693/815)	76.63% (269/351)	81.75% (242/296)
flow-designer	69.95% (652/932)	66.66% (356/534)	70.67% (200/283)
forms	86.91% (1701/1957)	76.69% (915/1193)	85.86% (480/559)
http	98.76% (80/81)	98% (49/50)	96.77% (30/31)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (66/66)	90.9% (10/11)	100% (16/16)

jmfrancois

If I compare to other logos it look like dark is not dark but colored.
would you mind to rename it ?

github-actions · 2023-09-29T07:49:40Z

Size Change: +66.3 kB (+1%)

Total Size: 13.2 MB

Filename	Size	Change
`./packages/icons/dist/react.esm.js`	584 kB	+15.5 kB (+3%)
`./packages/icons/dist/react.js`	623 kB	+16.6 kB (+3%)
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB	+112 B (+1%)
`./packages/icons/dist/TalendIcons.js`	751 kB	+18.4 kB (+3%)
`./packages/icons/dist/TalendIcons.min.js`	606 kB	+15.7 kB (+3%)

ℹ️ View Unchanged

Filename	Size	Change
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	105 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.9 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	163 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13.9 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js`	637 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	122 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB	0 B
`./packages/components/dist/TalendReactComponents.css`	402 kB	0 B
`./packages/components/dist/TalendReactComponents.js`	2.94 MB	0 B
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.47 kB	0 B
`./packages/components/dist/TalendReactComponents.min.css`	210 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js`	630 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.55 kB	0 B
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB	0 B
`./packages/containers/dist/TalendReactContainers.js`	540 kB	0 B
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.css`	1.73 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js`	106 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js`	371 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js`	64.6 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.css`	281 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.js`	1.07 MB	0 B
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.3 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.css`	172 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js`	211 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.33 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.8 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	453 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.51 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	17.1 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	104 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	52.7 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB	0 B
`./packages/forms/dist/TalendReactForms.css`	39.3 kB	0 B
`./packages/forms/dist/TalendReactForms.js`	780 kB	0 B
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.5 kB	0 B
`./packages/forms/dist/TalendReactForms.min.css`	13.4 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js`	206 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.54 kB	0 B
`./packages/http/dist/TalendHttp.js`	24.5 kB	0 B
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B	0 B
`./packages/http/dist/TalendHttp.min.js`	5.19 kB	0 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B	0 B
`./packages/icons/dist/bundle.js`	1.26 kB	0 B
`./packages/icons/dist/info.js`	26.1 kB	+82 B (0%)
`./packages/icons/dist/talendicons.css`	334 B	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B	0 B
`./packages/icons/dist/typeUtils.js`	14.4 kB	0 B
`./packages/jsfc/dist/index.js`	86.8 kB	0 B
`./packages/jsfc/dist/index.js.dependencies.json`	2 B	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	133 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	22 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B	0 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js`	96.4 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	10.6 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB	0 B
`./packages/storybook-docs/dist/globalStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	10.2 kB	0 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB	0 B
`./packages/theme/dist/bootstrap.css`	172 kB	0 B
`./packages/theme/dist/bootstrap.js`	2.51 kB	0 B
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B	0 B

_{compressed-size-action}

inna-i · 2023-09-29T07:51:17Z

@jmfrancois you are right, better to use colored word 👌

github-actions · 2023-09-29T07:51:19Z

4913

Demo is available here

feat(TDOPS-5220): add Talend Qlik white and dark logos

a68558d

inna-i temporarily deployed to pull_request_unsafe September 29, 2023 07:00 — with GitHub Actions Inactive

inna-i had a problem deploying to pull_request_unsafe September 29, 2023 07:00 — with GitHub Actions Error

Merge branch 'master' into innai/feat/TDOPS-5220/add-talend-qlik-logos

c6c95f8

inna-i temporarily deployed to pull_request_unsafe September 29, 2023 07:00 — with GitHub Actions Inactive

inna-i had a problem deploying to pull_request_unsafe September 29, 2023 07:00 — with GitHub Actions Failure

inna-i marked this pull request as ready for review September 29, 2023 07:00

inna-i had a problem deploying to pull_request_unsafe September 29, 2023 07:00 — with GitHub Actions Failure

aamalric-talend approved these changes Sep 29, 2023

View reviewed changes

inna-i added 3 commits September 29, 2023 10:08

fix: svg markup

d08f408

Merge github.com:Talend/ui into innai/feat/TDOPS-5220/add-talend-qlik…

f7ffc0c

…-logos

Merge branch 'innai/feat/TDOPS-5220/add-talend-qlik-logos' of github.…

fa3a605

…com:Talend/ui into innai/feat/TDOPS-5220/add-talend-qlik-logos

inna-i temporarily deployed to pull_request_unsafe September 29, 2023 07:09 — with GitHub Actions Inactive

inna-i had a problem deploying to pull_request_unsafe September 29, 2023 07:09 — with GitHub Actions Error

fix: svg names to avoid duplication

3bdb662

inna-i temporarily deployed to pull_request_unsafe September 29, 2023 07:23 — with GitHub Actions Inactive

inna-i temporarily deployed to pull_request_unsafe September 29, 2023 07:24 — with GitHub Actions Inactive

lmaillet approved these changes Sep 29, 2023

View reviewed changes

jmfrancois reviewed Sep 29, 2023

View reviewed changes

fix: change after code review

2ed2ca4

inna-i temporarily deployed to pull_request_unsafe September 29, 2023 07:53 — with GitHub Actions Inactive

inna-i merged commit 6af5614 into master Sep 29, 2023

inna-i deleted the innai/feat/TDOPS-5220/add-talend-qlik-logos branch September 29, 2023 09:15

inna-i temporarily deployed to pull_request_unsafe September 29, 2023 09:16 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(TDOPS-5220): add Talend Qlik white and dark logos #4913

feat(TDOPS-5220): add Talend Qlik white and dark logos #4913

inna-i commented Sep 29, 2023 •

edited

Loading

aamalric-talend left a comment

github-actions bot commented Sep 29, 2023 •

edited

Loading

jmfrancois left a comment

github-actions bot commented Sep 29, 2023 •

edited

Loading

inna-i commented Sep 29, 2023

github-actions bot commented Sep 29, 2023

feat(TDOPS-5220): add Talend Qlik white and dark logos #4913

feat(TDOPS-5220): add Talend Qlik white and dark logos #4913

Conversation

inna-i commented Sep 29, 2023 • edited Loading

aamalric-talend left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2023 • edited Loading

jmfrancois left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2023 • edited Loading

inna-i commented Sep 29, 2023

github-actions bot commented Sep 29, 2023

inna-i commented Sep 29, 2023 •

edited

Loading

github-actions bot commented Sep 29, 2023 •

edited

Loading

github-actions bot commented Sep 29, 2023 •

edited

Loading