fix(TDOPS-5327): prepare TUI to pnpm and solve some missing deps in packages #4929

smouillour · 2023-10-11T07:35:40Z

What is the problem this PR is trying to solve?
Prepare TUI to a potential move to PNPM (or at least fix talend script to be compatible in project side)

add some missing dependencies in packages

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

…ackages

smouillour · 2023-10-11T07:36:09Z

fork/dynamic-cdn-webpack-plugin/src/find.js

-					findPackagesFromNonScopeFolder(scope, name, nestedNodeModulesPath, []),
-				);
-			}
+			// NOT COMPATIBLE WITH PNPM


This is not compatible with PNPM, it should be ok to go without it

Note: Not sure of the impact of this change

This is a fix, we can't merge that. It was the only way to find all versions of a given modules.
For example if you have prop-types twice and one of them can not be hoisted.
But it is ok to keep the diff to work on the PR

smouillour · 2023-10-11T07:38:38Z

packages/design-docs/.storybook/main.js

 const iconConfig = require('@talend/icons/.storybook/main.js');
-const rootPath = require.resolve('@talend/design-docs').replace('src/index.ts', '');


@talend/design-docs should not depends on itself

smouillour · 2023-10-11T07:39:55Z

packages/storybook-docs/src/components/Statuses/Statuses.tsx

@@ -1,5 +1,4 @@
 import { Unstyled } from '@storybook/blocks';
-import { StackHorizontal, StackItem } from '@talend/design-system';


not used in the file

smouillour · 2023-10-11T07:40:42Z

packages/storybook-docs/src/components/Use.tsx

@@ -1,41 +1,37 @@
 import type { HTMLAttributes, ReactElement, PropsWithChildren } from 'react';
-// eslint-disable-next-line @talend/import-depth
-import { IconNameWithSize } from '@talend/icons/dist/typeUtils';


remove dependency to icons as icon depends on it (cycle deps)

smouillour · 2023-10-11T07:43:23Z

tools/scripts-config-storybook-lib/.storybook-templates/main.js

 			},
 		},
 	},
+	typescript: {


improvements for storybook

smouillour · 2023-10-11T07:43:47Z

tools/scripts-config-storybook-lib/.storybook-templates/msw/mockServiceWorker.js

@@ -2,7 +2,7 @@
 /* tslint:disable */

 /**
- * Mock Service Worker (0.49.3).
+ * Mock Service Worker (1.3.2).


command for msw has been run after upgrade

github-actions · 2023-10-11T08:08:17Z

4929

Demo is available here

github-actions · 2023-10-11T08:16:02Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.17% (1268/1422)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	89.95% (5609/6235)	81.02% (3212/3964)	86.88% (1418/1632)
containers	83.53% (1385/1658)	74.67% (687/920)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
faceted-search	85.03% (693/815)	76.63% (269/351)	81.75% (242/296)
flow-designer	69.95% (652/932)	66.66% (356/534)	70.67% (200/283)
forms	86.91% (1701/1957)	76.46% (916/1198)	85.86% (480/559)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (66/66)	90.9% (10/11)	100% (16/16)

github-actions · 2023-10-11T08:16:05Z

Size Change: 0 B

Total Size: 13.2 MB

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	105 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.9 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	163 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13.9 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js`	637 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB
`./packages/cmf/dist/TalendReactCmf.min.js`	122 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.css`	403 kB
`./packages/components/dist/TalendReactComponents.js`	2.94 MB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.47 kB
`./packages/components/dist/TalendReactComponents.min.css`	210 kB
`./packages/components/dist/TalendReactComponents.min.js`	630 kB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.55 kB
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB
`./packages/containers/dist/TalendReactContainers.js`	540 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.74 kB
`./packages/containers/dist/TalendReactContainers.min.js`	106 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB
`./packages/dataviz/dist/TalendReactDataviz.js`	371 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js`	64.6 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB
`./packages/design-system/dist/TalendDesignSystem.css`	281 kB
`./packages/design-system/dist/TalendDesignSystem.js`	1.07 MB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.3 kB
`./packages/design-system/dist/TalendDesignSystem.min.css`	172 kB
`./packages/design-system/dist/TalendDesignSystem.min.js`	211 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.33 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.8 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	453 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.51 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	17.1 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	104 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	52.7 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	39.3 kB
`./packages/forms/dist/TalendReactForms.js`	780 kB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.5 kB
`./packages/forms/dist/TalendReactForms.min.css`	13.4 kB
`./packages/forms/dist/TalendReactForms.min.js`	206 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.54 kB
`./packages/http/dist/TalendHttp.js`	24.9 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js`	5.33 kB
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.1 kB
`./packages/icons/dist/react.esm.js`	585 kB
`./packages/icons/dist/react.js`	623 kB
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js`	752 kB
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js`	607 kB
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.4 kB
`./packages/jsfc/dist/index.js`	86.8 kB
`./packages/jsfc/dist/index.js.dependencies.json`	2 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	133 kB
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	22 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB
`./packages/stepper/dist/TalendReactStepper.js`	96.4 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB
`./packages/stepper/dist/TalendReactStepper.min.js`	10.6 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	398 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB
`./packages/theme/dist/bootstrap.css`	172 kB
`./packages/theme/dist/bootstrap.js`	2.51 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

jmfrancois · 2023-10-11T09:34:07Z

packages/cmf-cqrs/package.json

@@ -33,13 +33,15 @@
  "homepage": "https://github.com/Talend/ui/cmf-cqrs#readme",
  "dependencies": {
    "@talend/react-cmf": "^7.3.0",
-    "@talend/utils": "2.6.0",


packages/components/package.json

jmfrancois · 2023-10-11T09:37:52Z

packages/components/package.json

    "@talend/locales-design-system": "^7.3.0",
    "@talend/locales-tui-components": "^9.5.0",
+    "@talend/scripts-config-stylelint": "^4.0.0",


this is not part of core but it should, so not here

jmfrancois · 2023-10-11T09:38:16Z

packages/components/package.json

    "@talend/scripts-core": "^15.0.0",
    "@talend/scripts-config-react-webpack": "^16.1.0",
+    "@talend/scripts-config-typescript": "^11.1.0",


it is already part of scripts core.

… identified

fix(TDOPS-5327): prepare TUI to pnpm and solve some missing deps in p…

d8a6638

…ackages

smouillour temporarily deployed to pull_request_unsafe October 11, 2023 07:35 — with GitHub Actions Inactive

smouillour had a problem deploying to pull_request_unsafe October 11, 2023 07:35 — with GitHub Actions Error

fix

90919b7

smouillour temporarily deployed to pull_request_unsafe October 11, 2023 07:38 — with GitHub Actions Inactive

smouillour had a problem deploying to pull_request_unsafe October 11, 2023 07:38 — with GitHub Actions Error

smouillour temporarily deployed to pull_request_unsafe October 11, 2023 07:38 — with GitHub Actions Inactive

smouillour had a problem deploying to pull_request_unsafe October 11, 2023 07:38 — with GitHub Actions Error

smouillour commented Oct 11, 2023

View reviewed changes

fix test

f8b7bde

smouillour temporarily deployed to pull_request_unsafe October 11, 2023 07:51 — with GitHub Actions Inactive

jmfrancois reviewed Oct 11, 2023

View reviewed changes

packages/components/package.json Outdated Show resolved Hide resolved

jmfrancois reviewed Oct 11, 2023

View reviewed changes

smouillour and others added 2 commits October 12, 2023 10:56

fix some lint + remove usage of talend-script when a circular deps is…

ad68589

… identified

Merge ad68589 into cd04f75

9130a06

smouillour temporarily deployed to pull_request_unsafe October 12, 2023 08:56 — with GitHub Actions Inactive

smouillour had a problem deploying to pull_request_unsafe October 12, 2023 08:56 — with GitHub Actions Error

smouillour temporarily deployed to pull_request_unsafe October 12, 2023 08:56 — with GitHub Actions Inactive

smouillour had a problem deploying to pull_request_unsafe October 12, 2023 08:56 — with GitHub Actions Error

github-actions bot and others added 2 commits October 12, 2023 09:01

chore: yarn-deduplicate

7176b54

remove usage of @talend/eslint-plugin + fix prettier version

c8bdf5b

smouillour temporarily deployed to pull_request_unsafe October 12, 2023 09:08 — with GitHub Actions Inactive

smouillour had a problem deploying to pull_request_unsafe October 12, 2023 09:08 — with GitHub Actions Failure

smouillour closed this Nov 16, 2023

smouillour deleted the smouillour/fix/TDOPS-5327-prepare-pnpm branch November 16, 2023 10:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(TDOPS-5327): prepare TUI to pnpm and solve some missing deps in packages #4929

fix(TDOPS-5327): prepare TUI to pnpm and solve some missing deps in packages #4929

smouillour commented Oct 11, 2023 •

edited

Loading

smouillour Oct 11, 2023

smouillour Oct 11, 2023

jmfrancois Oct 11, 2023 •

edited

Loading

smouillour Oct 11, 2023

smouillour Oct 11, 2023

smouillour Oct 11, 2023

smouillour Oct 11, 2023

smouillour Oct 11, 2023

smouillour Oct 11, 2023

github-actions bot commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

jmfrancois Oct 11, 2023

jmfrancois Oct 11, 2023

jmfrancois Oct 11, 2023

		const iconConfig = require('@talend/icons/.storybook/main.js');
		const rootPath = require.resolve('@talend/design-docs').replace('src/index.ts', '');

		@@ -1,5 +1,4 @@
		import { Unstyled } from '@storybook/blocks';
		import { StackHorizontal, StackItem } from '@talend/design-system';

fix(TDOPS-5327): prepare TUI to pnpm and solve some missing deps in packages #4929

fix(TDOPS-5327): prepare TUI to pnpm and solve some missing deps in packages #4929

Conversation

smouillour commented Oct 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmfrancois Oct 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smouillour commented Oct 11, 2023 •

edited

Loading

jmfrancois Oct 11, 2023 •

edited

Loading