feat(scripts-core): take a look at swc #4930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfrancois
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
jmfrancois
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Error
jmfrancois
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Error
jmfrancois
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
jmfrancois
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Error
jmfrancois
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
jmfrancois
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
jmfrancois
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
jmfrancois
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
jmfrancois
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
jmfrancois
commented
Oct 11, 2023
Comment on lines
-2
to
-3
| export createChainedFunction from './createChainedFunction'; | ||
| export ValidComponentChildren from './ValidComponentChildren'; |
There was a problem hiding this comment.
I don't know what this code is supposed to do but it is not supported by swc
Looking at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export this is not supposed to exists
Looking everywhere in react-bootstrap this is not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
We use the good and old babel. More and more tooling are poping using golang and rust outside.
We need to take a look and see what is the level of maturity of each
What is the chosen solution to this problem?
Today we take a look at https://swc.rs/
SWC means Speedy Web Compiler
It is Rust compiler which try to replace babel and tsc
First results show typescript support do not generate types, just transpile it, so as babel.
Please check if the PR fulfills these requirements
yarn changesetto a request a release from the CI if wanted.[ ] This PR introduces a breaking change