Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT PNPM 5 (more fixes) #4938

Merged
merged 20 commits into from
Oct 19, 2023
Merged

DRAFT PNPM 5 (more fixes) #4938

merged 20 commits into from
Oct 19, 2023

Conversation

smouillour
Copy link
Contributor

What is the problem this PR is trying to solve?

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@smouillour smouillour temporarily deployed to pull_request_unsafe October 17, 2023 13:22 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 17, 2023 17:27 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 17, 2023 17:31 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 17, 2023 17:36 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

Title Lines Statements Branches Functions
assets-api Coverage: 28%
 28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
 89.17% (1268/1422) 80.36% (618/769) 88.91% (361/406)
cmf-cqrs Coverage: 87%
 87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
 69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
 89.95% (5609/6235) 81.02% (3212/3964) 86.88% (1418/1632)
containers Coverage: 84%
 83.53% (1385/1658) 74.67% (687/920) 75.17% (327/435)
dataviz Coverage: 85%
 85.6% (321/375) 66.66% (160/240) 75.64% (118/156)
faceted-search Coverage: 85%
 85.03% (693/815) 76.63% (269/351) 81.75% (242/296)
flow-designer Coverage: 70%
 69.95% (652/932) 66.66% (356/534) 70.67% (200/283)
forms Coverage: 86%
 86.91% (1701/1957) 76.46% (916/1198) 85.86% (480/559)
http Coverage: 100%
 100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
 92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
 81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
 100% (66/66) 90.9% (10/11) 100% (16/16)

@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 00:05 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 00:05 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 07:21 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 19:07 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 19:07 — with GitHub Actions Inactive
smouillour and others added 2 commits October 18, 2023 21:19
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 19:19 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 19:19 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 19:26 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 19:26 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 20:05 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 18, 2023 20:05 — with GitHub Actions Inactive
@smouillour smouillour marked this pull request as ready for review October 19, 2023 12:59
@smouillour smouillour merged commit 813cdca into smouillour/fix/TDOPS-5327-pnpm Oct 19, 2023
5 of 8 checks passed
@smouillour smouillour deleted the smouillour/fix/TDOPS-5327-pnpm-5 branch October 19, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smouillour