fix(TDOPS-5386/utils): remove phone validation as not in use #4972

inna-i · 2023-11-07T14:41:25Z

What is the problem this PR is trying to solve?
TDOPS-5386: [TUI] Fix phone regexp

What is the chosen solution to this problem?

phone validation is removed as not in use
security issue fixed ✅

Please check if the PR fulfills these requirements

The PR has used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2023-11-07T15:07:19Z

4972

Demo is available here

github-actions · 2023-11-07T15:08:24Z

Size Change: -9.14 kB (0%)

Total Size: 13.4 MB

Filename	Size	Change
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	103 kB	-792 B (-1%)
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.3 kB	-514 B (-2%)
`./packages/cmf/dist/TalendReactCmf.js`	636 kB	-792 B (0%)
`./packages/cmf/dist/TalendReactCmf.min.js`	121 kB	-514 B (0%)
`./packages/components/dist/TalendReactComponents.js`	2.98 MB	-792 B (0%)
`./packages/components/dist/TalendReactComponents.min.js`	661 kB	-514 B (0%)
`./packages/containers/dist/TalendReactContainers.js`	539 kB	-792 B (0%)
`./packages/containers/dist/TalendReactContainers.min.js`	105 kB	-514 B (0%)
`./packages/design-system/dist/TalendDesignSystem.js`	1.18 MB	-792 B (0%)
`./packages/design-system/dist/TalendDesignSystem.min.js`	236 kB	-514 B (0%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	452 kB	-792 B (0%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	102 kB	-514 B (-1%)
`./packages/forms/dist/TalendReactForms.js`	778 kB	-792 B (0%)
`./packages/forms/dist/TalendReactForms.min.js`	205 kB	-514 B (0%)

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.css`	403 kB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB
`./packages/components/dist/TalendReactComponents.min.css`	210 kB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.74 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB
`./packages/dataviz/dist/TalendReactDataviz.js`	372 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js`	63.6 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.18 kB
`./packages/design-system/dist/TalendDesignSystem.css`	281 kB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.43 kB
`./packages/design-system/dist/TalendDesignSystem.min.css`	172 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.48 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.8 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.5 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	17.1 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	51.5 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	39.3 kB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.35 kB
`./packages/forms/dist/TalendReactForms.min.css`	13.4 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB
`./packages/http/dist/TalendHttp.js`	24.9 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js`	5.33 kB
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.1 kB
`./packages/icons/dist/react.esm.js`	585 kB
`./packages/icons/dist/react.js`	623 kB
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js`	752 kB
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js`	606 kB
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.4 kB
`./packages/jsfc/dist/index.js`	86.8 kB
`./packages/jsfc/dist/index.js.dependencies.json`	2 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB
`./packages/stepper/dist/TalendReactStepper.js`	97.4 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB
`./packages/stepper/dist/TalendReactStepper.min.js`	9.64 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	398 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB
`./packages/theme/dist/bootstrap.css`	172 kB
`./packages/theme/dist/bootstrap.js`	2.51 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

github-actions · 2023-11-07T15:12:32Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.19% (1271/1425)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.38% (5605/6201)	81.64% (3217/3940)	87.73% (1417/1615)
containers	83.53% (1385/1658)	74.67% (687/920)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
design-system	66.78% (905/1355)	48.59% (433/891)	53.33% (192/360)
faceted-search	85.03% (693/815)	76.63% (269/351)	81.75% (242/296)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.72% (1675/1954)	75.22% (902/1199)	84.43% (472/559)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (62/62)	90.9% (10/11)	100% (16/16)

fix(TDOPS-5386/utils): remove phone validation as not in use

5ce2bda

inna-i temporarily deployed to pull_request_unsafe November 7, 2023 14:41 — with GitHub Actions Inactive

inna-i had a problem deploying to pull_request_unsafe November 7, 2023 14:41 — with GitHub Actions Error

chore: generate chnageset

38c605e

inna-i temporarily deployed to pull_request_unsafe November 7, 2023 14:43 — with GitHub Actions Inactive

inna-i had a problem deploying to pull_request_unsafe November 7, 2023 14:43 — with GitHub Actions Failure

romainseb approved these changes Nov 7, 2023

View reviewed changes

fix: remove PHONE import

03eb316

inna-i temporarily deployed to pull_request_unsafe November 7, 2023 14:47 — with GitHub Actions Inactive

inna-i enabled auto-merge (squash) November 8, 2023 07:32

lmaillet approved these changes Nov 8, 2023

View reviewed changes

inna-i merged commit 841be39 into master Nov 8, 2023
8 checks passed

inna-i deleted the innai/fix/TDOPS-5386/remove-phone-validation branch November 8, 2023 07:36

inna-i had a problem deploying to pull_request_unsafe November 8, 2023 07:36 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(TDOPS-5386/utils): remove phone validation as not in use #4972

fix(TDOPS-5386/utils): remove phone validation as not in use #4972

inna-i commented Nov 7, 2023 •

edited

Loading

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

fix(TDOPS-5386/utils): remove phone validation as not in use #4972

fix(TDOPS-5386/utils): remove phone validation as not in use #4972

Conversation

inna-i commented Nov 7, 2023 • edited Loading

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

inna-i commented Nov 7, 2023 •

edited

Loading