Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ARCH-737): add ESM support (recovery PR) #5329

Merged
merged 62 commits into from
Jun 10, 2024
Merged

feat(ARCH-737): add ESM support (recovery PR) #5329

merged 62 commits into from
Jun 10, 2024

Conversation

smouillour
Copy link
Contributor

@smouillour smouillour commented Jun 7, 2024 •
edited
Loading

What is the problem this PR is trying to solve?

our lib are in the CommonJS format.
We want to move forward by using vite as bundler which is the common mainstream tool today to work on react.
To achieve that we need to modernize our libraries and start to push ESM format.

Original PR: #5263

What is the chosen solution to this problem?

  • add script to start the playground with vite
  • add output esm configuration to all ui libraries (packages and fork)

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

jmfrancois and others added 30 commits April 9, 2024 10:55
@jmfrancois
feat(ARCH-737): add ESM support
fc62669
@jmfrancois
Merge fc62669 into f4889d3
682110c
@github-actions
chore: yarn-deduplicate
af34033
@smouillour
Add esm in containers and components
2c34921
@smouillour
lock file
028541a
@jmfrancois
Merge 028541a into f4889d3
38c70ef
@github-actions
chore: yarn-deduplicate
d6d843c
@smouillour
fix sass + add alias
8d25e90
@smouillour
design-system, icons and utils
b0e782d
@smouillour
fix icons
c89a3b4
@smouillour
design-tokens
4a8e04d
@smouillour
react-bootstrap, a11y, cmf, forms
52cfee9
@smouillour
sync with master
0093762
@smouillour
cmf-router, dataviz, design-tokens and faceted-search
1e1a39c
@smouillour
design-tokens
bfee817
@smouillour
storybook-docs and theme: upgrade sass-loader and fix use tokens
afef114
@smouillour
scripts-config-react-webpack upgrade sass-loader
df48569
@smouillour
json-schema-form-core: add esm, ds fix ts issue
c0fcb86
@smouillour
playground: make it works (almost)
e0c2e82
@jmfrancois
Merge e0c2e82 into 48865e5
728ba83
@github-actions
chore: yarn-deduplicate
6eeaf7d
@smouillour
mockVite playground
d3ef679
@jmfrancois
Merge d3ef679 into 48865e5
4c278ce
@github-actions
chore: yarn-deduplicate
8307c70
@jmfrancois
fix: build pass on storybook-docs
d21d8b0
@smouillour
change target for esm to lib-esm
6e87a26
@smouillour
revert previous commit
7bb2022
@smouillour
fix webpack config for theme
fd500c5
@smouillour
upgrade sass and use modern-compiler in storybook-docs
76a76d7
@smouillour
add sassOptions to theme
b892265
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 13:22 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 13:22 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 13:22 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 13:52 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 13:52 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 13:52 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 13:52 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 14:08 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 14:08 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 14:08 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 14:08 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 15:33 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 15:33 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 15:33 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 7, 2024 15:33 — with GitHub Actions Inactive
Gbacc
Gbacc approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@Gbacc Gbacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to take a look at every single piece but it looks good

@smouillour smouillour temporarily deployed to pull_request_unsafe June 10, 2024 09:57 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 10, 2024 09:57 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 10, 2024 09:57 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe June 10, 2024 09:57 — with GitHub Actions Inactive
@smouillour smouillour merged commit 3bd16fc into master Jun 10, 2024
10 checks passed
@smouillour smouillour deleted the smouillour/feat/add-esm-no-merge branch June 10, 2024 13:11
@smouillour smouillour had a problem deploying to pull_request_unsafe June 10, 2024 13:11 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VolodymyrKovalM VolodymyrKovalM VolodymyrKovalM approved these changes

@jmfrancois jmfrancois jmfrancois approved these changes

@Gbacc Gbacc Gbacc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smouillour @Gbacc @jmfrancois @VolodymyrKovalM