feat(ARCH-737): removed unused tsconfig.esm.json #5362

smouillour · 2024-06-27T07:39:42Z

What is the problem this PR is trying to solve?
We have some unused tsconfig.esm.json
Those has been added at the beginning of the POC to replace babel by TSC but finally we decided to continue to use babel, but we forgot to remove them.

What is the chosen solution to this problem?
Remove all tsconfig.esm.json

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2024-06-27T07:51:27Z

5362

Demo is available here

github-actions · 2024-06-27T08:05:10Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.18% (1237/1387)	80.88% (605/748)	89.28% (350/392)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.79% (5522/6082)	81.85% (3198/3907)	88.2% (1391/1577)
containers	83.71% (1388/1658)	74.81% (692/925)	75.17% (327/435)
dataviz	85.44% (323/378)	66.66% (160/240)	75.79% (119/157)
design-system	66.75% (996/1492)	50.85% (536/1054)	54.54% (216/396)
faceted-search	85.69% (677/790)	79.31% (303/382)	82.63% (238/288)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.79% (1637/1908)	75.69% (925/1222)	84.24% (460/546)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (73/73)	90.9% (10/11)	100% (24/24)

github-actions · 2024-06-27T08:09:04Z

Size Change: 0 B

Total Size: 16.9 MB

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.09 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.32 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	205 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	670 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	11.3 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	693 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	12.7 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js`	505 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.3 kB
`./packages/cmf/dist/TalendReactCmf.min.js`	65.1 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.css`	397 kB
`./packages/components/dist/TalendReactComponents.js`	4.73 MB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB
`./packages/components/dist/TalendReactComponents.min.css`	212 kB
`./packages/components/dist/TalendReactComponents.min.js`	1.26 MB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB
`./packages/containers/dist/TalendReactContainers.css`	2.99 kB
`./packages/containers/dist/TalendReactContainers.js`	634 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.4 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.78 kB
`./packages/containers/dist/TalendReactContainers.min.js`	92.8 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.45 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.1 kB
`./packages/dataviz/dist/TalendReactDataviz.js`	371 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12.2 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js`	59.5 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.18 kB
`./packages/design-system/dist/TalendDesignSystem.css`	332 kB
`./packages/design-system/dist/TalendDesignSystem.js`	1.37 MB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.52 kB
`./packages/design-system/dist/TalendDesignSystem.min.css`	215 kB
`./packages/design-system/dist/TalendDesignSystem.min.js`	245 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.56 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	79.1 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.7 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	75 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.4 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	19.1 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	542 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.54 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	6.28 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	100 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.59 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	50.8 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	20.9 kB
`./packages/forms/dist/TalendReactForms.js`	1.46 MB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.35 kB
`./packages/forms/dist/TalendReactForms.min.css`	6.2 kB
`./packages/forms/dist/TalendReactForms.min.js`	267 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB
`./packages/http/dist/TalendHttp.js`	24.6 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js`	5.3 kB
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.8 kB
`./packages/icons/dist/react.esm.js`	614 kB
`./packages/icons/dist/react.js`	654 kB
`./packages/icons/dist/talend-icons-webfont.css`	18.3 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js`	787 kB
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js`	636 kB
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.5 kB
`./packages/router-bridge/dist/TalendRouterBridge.js`	135 kB
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.8 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	349 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	361 B
`./packages/stepper/dist/TalendReactStepper.css`	2.41 kB
`./packages/stepper/dist/TalendReactStepper.js`	97.9 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB
`./packages/stepper/dist/TalendReactStepper.min.css`	1.2 kB
`./packages/stepper/dist/TalendReactStepper.min.js`	9.37 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.3 kB
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	384 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.5 kB
`./packages/theme/dist/bootstrap.css`	171 kB
`./packages/theme/dist/bootstrap.js`	2.38 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

smouillour added 2 commits June 27, 2024 09:36

feat(ARCH-737): removed unused tsconfig.esm.json

937b451

add changeset

e141d6d

smouillour temporarily deployed to pull_request_unsafe June 27, 2024 07:39 — with GitHub Actions Inactive

smouillour had a problem deploying to pull_request_unsafe June 27, 2024 07:39 — with GitHub Actions Error

smouillour marked this pull request as ready for review June 27, 2024 07:39

romainseb approved these changes Jun 27, 2024

View reviewed changes

Gbacc approved these changes Jun 27, 2024

View reviewed changes

mhuchet approved these changes Jun 27, 2024

View reviewed changes

Merge branch 'master' into smouillour/fix/remove-tsconfig-esm

21c6324

smouillour temporarily deployed to pull_request_unsafe June 27, 2024 07:52 — with GitHub Actions Inactive

smouillour enabled auto-merge (squash) June 27, 2024 07:52

smouillour merged commit f321a0d into master Jun 27, 2024
9 checks passed

smouillour deleted the smouillour/fix/remove-tsconfig-esm branch June 27, 2024 08:05

smouillour had a problem deploying to pull_request_unsafe June 27, 2024 08:05 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ARCH-737): removed unused tsconfig.esm.json #5362

feat(ARCH-737): removed unused tsconfig.esm.json #5362

smouillour commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

feat(ARCH-737): removed unused tsconfig.esm.json #5362

feat(ARCH-737): removed unused tsconfig.esm.json #5362

Conversation

smouillour commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024