Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TMC-4076): upgrade react-is to v18.3.1 #5443

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

smouillour
Copy link
Contributor

What is the problem this PR is trying to solve?
with PNPM, design-system is twice in the lockfile due to two versions of react-is (17 and 18)

What is the chosen solution to this problem?
Upgrade react-is to v18.3.1
In design-system switch from peerDep to Dep

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Storybook for this PR deployed on this github page

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Title Lines Statements Branches Functions
assets-api Coverage: 28%
28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
89.18% (1237/1387) 80.88% (605/748) 89.28% (350/392)
cmf-cqrs Coverage: 87%
87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
90.8% (5528/6088) 81.84% (3206/3917) 88.14% (1390/1577)
containers Coverage: 84%
83.59% (1391/1664) 74.3% (694/934) 75% (327/436)
dataviz Coverage: 85%
85.44% (323/378) 66.66% (160/240) 75.79% (119/157)
design-system Coverage: 67%
66.57% (1012/1520) 50.56% (537/1062) 53.84% (217/403)
faceted-search Coverage: 85%
85.08% (639/751) 78.63% (287/365) 81.88% (226/276)
flow-designer Coverage: 70%
70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 85%
85.81% (1640/1911) 75.77% (929/1226) 84.24% (460/546)
http Coverage: 100%
100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
100% (73/73) 90.9% (10/11) 100% (24/24)

@smouillour smouillour merged commit d1f8b6b into master Nov 5, 2024
7 checks passed
@smouillour smouillour deleted the smouillour/fix/upgrade-react-is branch November 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants