-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: portfolio performance improvements #1746
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
However I am kinda sad seeing the count up go, I've create an example where we can keep it while virtualizing the rows without too much change in the current virtualization.
Have a look and let us know if you like it: #1750
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
authorisedSites$
observable, as it s wrapped in a bind (has a built-in shareReplay)balances.each
(which changes on each read, nullifying the memo effect) to have a dependency onbalances
instead.@tanstack/react-virtual