Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move sapi to its own package #1779

Merged
merged 5 commits into from
Jan 21, 2025
Merged

chore: move sapi to its own package #1779

merged 5 commits into from
Jan 21, 2025

Conversation

0xKheops
Copy link
Contributor

@0xKheops 0xKheops commented Jan 9, 2025

No description provided.

@socket-security Socket Security
Copy link

socket-security bot commented Jan 9, 2025 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 351 kB mikemcl
npm/[email protected] None +1 101 kB feross
npm/[email protected] environment, filesystem 0 79.1 kB motdotla
npm/[email protected] None 0 73.4 kB lpinca

🚮 Removed packages: npm/@substrate/[email protected], npm/@supercharge/[email protected], npm/@svgr/[email protected], npm/@swc/[email protected], npm/@tailwindcss/[email protected], npm/@tailwindcss/[email protected], npm/@talismn/[email protected], npm/@talismn/[email protected], npm/@tanstack/[email protected], npm/@tanstack/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@vitejs/[email protected], npm/@zondax/[email protected], npm/@zxing/[email protected], npm/@zxing/[email protected]

View full report↗︎

@0xKheops 0xKheops marked this pull request as ready for review January 10, 2025 07:22
@0xKheops 0xKheops requested review from chidg and alecdwm January 10, 2025 07:22
alecdwm
alecdwm previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@alecdwm alecdwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chidg
chidg previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will need to test FF build after merge

@0xKheops 0xKheops dismissed stale reviews from chidg and alecdwm via 5d13db7 January 21, 2025 06:22
@0xKheops 0xKheops enabled auto-merge (squash) January 21, 2025 06:43
chidg
chidg approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xKheops 0xKheops merged commit d4ebb87 into dev Jan 21, 2025
6 checks passed
@0xKheops 0xKheops deleted the chore/share-sapi branch January 21, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidg chidg chidg approved these changes

@alecdwm alecdwm alecdwm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xKheops @alecdwm @chidg