Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize failed to update metadata error message #1789

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: normalize failed to update metadata error message #1789

merged 1 commit into from
Jan 24, 2025

Conversation

0xKheops
Copy link
Contributor

simplifies the error message for when backend can't update metadata, so that:

  • all errors have the same message and will be grouped together in sentry
  • the chainId of target chain, if known, is added as extra property in the sentry payload

@0xKheops 0xKheops enabled auto-merge (squash) January 22, 2025 02:37
@0xKheops 0xKheops requested a review from chidg January 22, 2025 02:37
chidg
chidg approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xKheops 0xKheops merged commit ecb9178 into dev Jan 24, 2025
6 checks passed
@0xKheops 0xKheops deleted the fix/normalize-failed-to-update-metadata-error branch January 24, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidg chidg chidg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xKheops @chidg