Fix GCC warning about array-bounds in BlockChainCache.cpp when replac…

…ing contents of std::vector

src/CryptoNoteCore/BlockchainCache.cpp

@@ -1,6 +1,6 @@
 // Copyright (c) 2012-2017, The CryptoNote developers, The Bytecoin developers
 // Copyright (c) 2018-2019, The Bittorium developers
-// Copyright (c) 2019, The Talleo developers
+// Copyright (c) 2019-2024, The Talleo developers
 //
 // This file is part of Bytecoin.
 //
@@ -270,8 +270,9 @@ std::unique_ptr<IBlockchainCache> BlockchainCache::split(uint32_t splitBlockInde
   splitKeyOutputsGlobalIndexes(*newCache, splitBlockIndex);
 
   fixChildrenParent(newCache.get());
-  newCache->children = children;
-  children = { newCache.get() };
+  newCache->children = std::move(children);
+  children.clear();
+  children.push_back(newCache.get());
 
   logger(Logging::DEBUGGING) << "Split successfully completed";
   return std::move(newCache);