Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to create new user from django admin panel #469

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

sbeach92
Copy link
Contributor

@sbeach92 sbeach92 commented Feb 9, 2024

Django admin panel crashed error with null birthday, when tried to add new custom user. Adding all fields that are present on mylsa add user field it is now possible to add custom user trough django admin panel.

Django admin panel crashed error with null birthday,
when tried to add new custom user. Adding all fields
that are present on mylsa add user field it is now
possible to add custom user trough django admin panel.

Is mylsa page still neede as it seems it is shown only
to admin profiles?

Signed-off-by: Erkki Hietaranta <[email protected]>
Signed-off-by: Erkki Hietaranta <[email protected]>
@olmari olmari self-requested a review February 25, 2024 21:12
Copy link
Collaborator

@olmari olmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks proper in view, tells when missing required fields, generates user okay and sends email, so follows business logic exactly.

@olmari olmari merged commit 2213ddb into TampereHacklab:master Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants