Mulysa limit service payment #476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction Custom invoice payment is carried by modified _service_paid_by_transaction function. Funcion has add_days input variable. Fixes issue: TampereHacklab#270 Signed-off-by: Erkki Hietaranta <[email protected]>
Child subscription paid to date is calculated from days added to Parrent subscription. Days that single payment adds are substracted from days to add to Parent subscription. This is "virtualy" payment date. Single payment days of child subscription is added to virtual payment date. Signed-off-by: Erkki Hietaranta <[email protected]>
Some users might found Dynamic pricing of payments missleading as normal access fee can be paid with dynamic pricing, but reorrucing custom invoice recalls flat rate. This commit changes custom invoice logic so that it allows dynamic pricing. Minimium payment is calculated from service minimum payment * service payment times. It can be disabled from settings.py or constance admin panel Signed-off-by: Erkki Hietaranta <[email protected]>
Child service is paid by calling funcion again. So now if child service has childs, they get paid. Updated calcultaion so that multpile custominvoices wont break basic idea of child payments.
Updated transaction commenting so that steps of transaction is easy to read Signed-off-by: Erkki Hietaranta <[email protected]>
Admin can control if custom invoice can be paid multiple times. Signed-off-by: Erkki Hietaranta <[email protected]>
Signed-off-by: Erkki Hietaranta <[email protected]>
Signed-off-by: Erkki Hietaranta <[email protected]>
Payment is prevented and transaction will taced unused if maximum allowed prepayment time is exceeded. Signed-off-by: Erkki Hietaranta <[email protected]>
Signed-off-by: Erkki Hietaranta <[email protected]>
Signed-off-by: Erkki Hietaranta <[email protected]>
Added transactino comments and userlog enteries for maximum services. Currently if basic transaction or custominvoice limits are reached nothing happens. If main service gets paid, child service gets paid to maximum limit. Signed-off-by: Erkki Hietaranta <[email protected]>
sbeach92
force-pushed
the
Mulysa-limit-service
branch
from
8ca8518
to
733201d
Compare
|
I don't understand why the amount should be variable when paying as the amount is dynamic already when the custom invoice is created? |
Because it can easily be and admin can change beheviour. As many users didn't understand idea of custom invoice to be onetime use only, so they would assume it works like standard payment. Not sure if still problem as custom invoices ar now in better hide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull reguest adds feature that initialise member service maximum payment date field.
If transaction or custom invoice hits the limit, transaction is not used.
Child services gets paid to max limit but some benefit is lost and that is not tracked.