-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core) onSubmit meta #1131
base: main
Are you sure you want to change the base?
feat(core) onSubmit meta #1131
Conversation
View your CI Pipeline Execution ↗ for commit ffd8138.
☁️ Nx Cloud last updated this comment at |
85da305
to
ebe6936
Compare
194411d
to
50404a6
Compare
I'm going to give it a go as the generic not extending object, I'm a little unsure why I started with it like this. But, I think restricting the user to what type they can define is a miss-step. |
1c981db
to
d43120a
Compare
27cffc8
to
9531990
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
+ Coverage 87.86% 87.88% +0.02%
==========================================
Files 30 30
Lines 1318 1321 +3
Branches 354 353 -1
==========================================
+ Hits 1158 1161 +3
Misses 144 144
Partials 16 16 ☔ View full report in Codecov by Sentry. |
From issue #989, this PR introduces onSubmitMeta to the formApi.
Example API shamelessly ripped from #989 and @crutchcorn