Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-query): add support for react19 in v4 #8441

Draft
wants to merge 6 commits into
base: v4
Choose a base branch
from

Conversation

gwansikk
Copy link
Contributor

@gwansikk gwansikk commented Dec 15, 2024

Hello! I am the maintainer of the Suspensive (react-query community project)

With the release of React 19 Stable, we are working to make Suspensive compatible with React 19 as well. However, we are encountering an issue because react-query v4 does not yet support React 19. To address this, I propose that react-query v4 should also include React 19 in its package dependencies.

  • Community project libraries using react-query v4 may face similar issues, especially if those libraries aim to support React 19.
  • I still believe that React Query v4 should support React 19. React 19 has similar browser compatibility to its predecessor, React 18, and I think v4 can be sufficiently used instead of v5 to support more browsers and be utilized in environments using React 19.

Copy link

nx-cloud bot commented Dec 15, 2024

View your CI Pipeline Execution ↗ for commit 6fc23c3.

Command Status Duration Result
nx affected --targets=test:lib --base=92e5672f5... ❌ Failed 15s View ↗
nx affected --targets=test:eslint,test:lib,test... ❌ Failed 1m 2s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-25 16:10:04 UTC

@manudeli
Copy link
Contributor

@gwansikk Cool! PeerDep of other packages depending on react should be updated!

@gwansikk gwansikk changed the title chore(react-query): add support for react19 in react-query v4 chore(react-query): support for react19 in react-query v4 Dec 15, 2024
@gwansikk gwansikk changed the title chore(react-query): support for react19 in react-query v4 chore(react-query): add support for react19 in v4 Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants