Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8453 Experiments #8481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

8453 Experiments #8481

wants to merge 1 commit into from
+2 −2

Conversation

Nick-Lucas
Copy link
Contributor

Experiments with #8453

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 28, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 31adb80.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 44s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 9s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-29 19:46:33 UTC

@Nick-Lucas Nick-Lucas closed this Dec 28, 2024
@Nick-Lucas Nick-Lucas reopened this Dec 28, 2024
@Nick-Lucas Nick-Lucas marked this pull request as ready for review December 28, 2024 22:55
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 28, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8481

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8481

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8481

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8481

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8481

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8481

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8481

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8481

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8481

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8481

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8481

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8481

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8481

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8481

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8481

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8481

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8481

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8481

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8481

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8481

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8481

commit: 31adb80

@codecov Codecov
Copy link

codecov bot commented Dec 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.05%. Comparing base (7ade233) to head (31adb80).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8481       +/-   ##
===========================================
+ Coverage   46.23%   63.05%   +16.82%     
===========================================
  Files         199      135       -64     
  Lines        7512     4807     -2705     
  Branches     1712     1345      -367     
===========================================
- Hits         3473     3031      -442     
+ Misses       3664     1536     -2128     
+ Partials      375      240      -135
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.65% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.57% <ø> (ø)
@tanstack/query-devtools 4.78% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.54% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.45% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo
Copy link
Collaborator

TkDodo commented Dec 29, 2024

Does this work?

@Nick-Lucas
Copy link
Contributor Author

Nope 😞

Might need to find some backup on this one, the answer may be really simple but I've never seen anything like it and the generated .d.ts for RQ seems correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nick-Lucas @TkDodo