Skip to content

feat(eslint-plugin): refactor infinite-query-property-order and add mutation-property-order rule #9191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

feat(eslint-plugin): refactor infinite-query-property-order and add mutation-property-order rule #9191

merged 2 commits into from
May 26, 2025

Conversation

jochongs
Copy link
Contributor

What

  • refactorinfinite-query-property-order
  • Add mutation-property-order rule

Why

In PR #9186, I originally added a new mutation-property-order.rule. But I later realized that it duplicated much of the existing infinite-query-property-order.rule logic.
This PR adresses that by introducing createPropertyOrderRule to encapsulate the shared behavior, improving maintainability and reducing duplication.

issue: #8988

@jochongs jochongs mentioned this pull request May 26, 2025
Open
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 26, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 499fd24.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 47s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 43s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-26 13:17:20 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 26, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9191

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9191

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9191

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9191

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9191

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9191

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9191

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9191

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9191

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9191

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9191

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9191

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9191

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9191

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9191

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9191

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9191

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9191

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9191

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9191

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9191

commit: 499fd24

@codecov Codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (b2af568) to head (499fd24).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9191       +/-   ##
===========================================
+ Coverage   45.19%   83.24%   +38.04%     
===========================================
  Files         206       19      -187     
  Lines        8240      549     -7691     
  Branches     1861      205     -1656     
===========================================
- Hits         3724      457     -3267     
+ Misses       4076       70     -4006     
+ Partials      440       22      -418
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 83.24% <95.55%> (+0.21%) ⬆️
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit a1210cb into TanStack:main May 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Newbie012 Newbie012 Newbie012 approved these changes

@schiller-manuel schiller-manuel Awaiting requested review from schiller-manuel

Assignees
No one assigned
Labels
package: eslint-plugin-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jochongs @Newbie012 @TkDodo