Support Map and Set as query keys
#9199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON.stringify doesn't properly support instances of these types and will just return "{}".
xref TanStack#6444
|
we want to keep being json compatible because it’s hard to justify drawing a line otherwise. If we add maps and sets, why not symbols? Why not Date? Why not You can always add a global |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is intended to be supported but I figured it wouldn't hurt to open this pr. Feel free to close if we don't want to support
MapandSetinstances as query keys. But I found this useful for me.JSON.stringify doesn't properly support instances of these types and will just return "{}". xref #6444