perf: improve performance of util function "difference" in quriesObserver.ts in query-core package #9201
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit ab1b07f.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9201 +/- ##
===========================================
+ Coverage 45.19% 59.56% +14.36%
===========================================
Files 206 138 -68
Lines 8240 5485 -2755
Branches 1861 1468 -393
===========================================
- Hits 3724 3267 -457
+ Misses 4076 1921 -2155
+ Partials 440 297 -143 🚀 New features to boost your workflow:
|
novice0840
changed the title
TkDodo
reviewed
Jun 2, 2025
| @@ -10,7 +10,7 @@ import type { | |||
| import type { QueryClient } from './queryClient' | |||
|
|
|||
| function difference<T>(array1: Array<T>, array2: Array<T>): Array<T> { | |||
| return array1.filter((x) => !array2.includes(x)) | |||
| return array1.filter((x) => !new Set(array2).has(x)) | |||
There was a problem hiding this comment.
can we move the new Set creation out of the filter function to only create the Set once ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the internal behavior of the "difference" function in quriesObserver.ts from includes function to using has function in sets
And this is faster when the arrays are longer. I included a link to the code sandbox below so you can see the specific performance differences.
Codesandbox Link
https://codesandbox.io/p/devbox/crazy-cherry-627tsr