-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move @tanstack/router-devtools
to @tanstack/react-router-devtools
#3083
base: main
Are you sure you want to change the base?
Conversation
01498d0
to
6efa18e
Compare
View your CI Pipeline Execution ↗ for commit 95a6e02.
☁️ Nx Cloud last updated this comment at |
we would need to still have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be the best approach here. At the moment, this would be a 'no-go' since it'd break people currently using the @tanstack/router-devtools
package with no fallback.
As a whole, however, it'd be worth asking @ardeora on his thoughts here, since there's potential for following Query's approach for the devtools as a whole.
If done so, we could have the following package structure, which I believe would be the better approach here.
router-devtools-core
react-router-devtools
router-devtools
(proxies everything fromreact-router-devtools
with a console warning asking them to switch packages and commitment that'd we'd drop this package in v2)
while we are at restructuring, we should also keep in mind start's devtools (hopefully coming soon @ardeora :) ) |
36aa907
to
4ddc603
Compare
I have added a To make sure nothing is broken by this change, the |
The current router-devtools package is specific to react.
This PR moves the react devtools to react-router-devtools, allowing for addition of e.g. solid-router-devtools, and for collection of shared functions in an agnostic core devtools package to the extend it makes sense in this context.
Since the
@tanstack/react-router-devtools
isn't published, this PR doesn't change the docs (.md files) or the examples/* folder which rely on specific published versions (rather than workspace packages)