-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-router): add NotFoundErrorData interface for improved type safety #3112
Open
Sheraff
wants to merge
8
commits into
TanStack:main
Choose a base branch
from
Sheraff:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of those two things should be correct
Sheraff
changed the title
feat'react-router): add NotFoundErrorData interface for improved type safety
feat(react-router): add NotFoundErrorData interface for improved type safety
Jan 5, 2025
View your CI Pipeline Execution ↗ for commit 1eafefc.
☁️ Nx Cloud last updated this comment at |
might be worth extending the existing Register interface already used for registering the router type, rather than adding a new interface for the same purpose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a demo of this PR, throwing type-safe
notFound
errors: https://stackblitz.com/edit/tanstack-router-fyrpy35d?file=src%2Froutes%2Findex.tsxCurrently the
notFound()
function accepts a params object with the shape ofNotFoundError
that is then passed as props to thenotFoundComponent
.Arbitrary data can be send through this mechanism with the
data?: any
key ofNotFoundError
, but thisany
prevents us from creating type-safe "not found" errors.This PR proposes that users should be able to define their own
data
shape through the global augmentation of a new interfaceNotFoundErrorData
. For example:This PR uses this new interface in a way that will preserve
data?: any
as the default if it is not globally augmented:Closes #3113