fix(react-router): separate internal and user provided history state #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferretwithaberet
changed the title
|
View your CI Pipeline Execution ↗ for commit 5ef8728.
☁️ Nx Cloud last updated this comment at |
tannerlinsley
pushed a commit
that referenced
this pull request
Jan 14, 2025
tannerlinsley
added a commit
that referenced
this pull request
Jan 15, 2025
* checkpoint * checkpoint * cleanup * checkpoint * client babel now works, runtime and rpc injection * fix: dont touch anything outside of the function * server functions now import a tsr-serverfn-split file version * checkpoint * checkpoint * fis tests * It's working!!! * move serverFnFetcher to start client * fix: no extra context, throw errors from middleware * docs: add custom link example for mantine (#3033) * ci: apply automated fixes * fix(react-router): make sure full matches are passed into route functions (#3039) * release: v1.91.3 * docs: minor typo in code-based-routing.md (#3043) * feat(start): create-start cli (#2920) * create start cli * update lockfile * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * docs: Minor typo in middleware.md (#3042) * release: v1.92.0 * refactor(react-router): expose `scrollBehavior` on the `ScrollRestoration` component (#3053) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Sean Cassiere <[email protected]> * release: v1.92.1 * fix(start): returning `null` from server functions (#3048) Co-authored-by: SeanCassiere <[email protected]> * release: v1.92.2 * fix: allow serverFn errors to also have context (#3037) * fix: allow serverFn errors to also have context * fix: allow errors, undefined from server functions * remove logs * fix: transformer and tests * ci: apply automated fixes * no logs * fix conficts --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * release: v1.92.3 * move directive plugin to own package * fixes, tests * suggested fixes from sean * fix tests * fix: import specifier * fix: dev imports * fix: simpler config, better logging, more reliable plugin coordination * fix: update test snapshots * fix: non-split directives, clean up compilers, logging, and * fix: production server fn builds * feat(start): explicitly enable and disable route generation * fix: $fetch during dev * ci: apply automated fixes * Update comparison.md * docs: remove duplicate word (#3125) * docs: remove duplicate word * docs: correct typo in learn-the-basics.md * chore: add skipLibCheck to examples (#3134) * docs: Typo issue - getParent Does not Exists in type RouteOptions (#3131) * docs: Fix notFound import (#3133) * docs: fix dead link and typo in guide (#3136) Typo introduced in #2963. * fix(react-router): separate internal and user provided history state (#3119) * release: v1.95.2 * fix(router-generator) use explicit routes export by default (#3109) Co-authored-by: Vladimir Panov <[email protected]> * fix(start): serialize `FormData` for server function input (#3138) * release: v1.95.3 * test(react-router): check `FormData` serialization in transformer (#3139) * docs(router): missing character in code-splitting guide (#3143) * fix(create-start): readme changes and little fixes (#3142) * release: v1.95.4 * fix(start): preserve multiple values for same key in `FormData` serialization (#3140) Co-authored-by: SeanCassiere <[email protected]> * release: v1.95.5 * docs(migrate): correct typo in migration documentation (#3153) * docs(start): fix `FormData` server functions examples (#3062) Co-authored-by: Sean Cassiere <[email protected]> * docs(router): require the use of React's `createRoot` function (#3151) Co-authored-by: Sean Cassiere <[email protected]> * fix: order of injected scripts (#3158) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * release: v1.95.6 * perf(start): reduce instantiations of server fn and middleware (again) (#3168) * perf: reduce instantiations of server fns * perf(start): reduce instantiations of middleware * release: v1.95.7 * fix imports * fix: build test --------- Co-authored-by: Youssef Benlemlih <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Manuel Schiller <[email protected]> Co-authored-by: Tanner Linsley <[email protected]> Co-authored-by: AlexisPin <[email protected]> Co-authored-by: timoconnellaus <[email protected]> Co-authored-by: Arnaud Kleinpeter <[email protected]> Co-authored-by: Joshua Knauber <[email protected]> Co-authored-by: Sean Cassiere <[email protected]> Co-authored-by: alakhpc <[email protected]> Co-authored-by: Mark Vu <[email protected]> Co-authored-by: Christopher Horobin <[email protected]> Co-authored-by: Muthu Kumar <[email protected]> Co-authored-by: Jeff Hertzler <[email protected]> Co-authored-by: Philippe Serhal <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Volodymyr <[email protected]> Co-authored-by: Vladimir Panov <[email protected]> Co-authored-by: pierluigigiancola <[email protected]> Co-authored-by: Tom Ballinger <[email protected]> Co-authored-by: Ben Durrant <[email protected]> Co-authored-by: Lukas Frey <[email protected]> Co-authored-by: John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
__TSR_indexbeing required when navigating with custom user provided state.fixes #3130