Support and require Rails 7.2 #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
support-rails-7-2
branch
5 times, most recently
from
b241609 to
96278ae
Compare
joshuay03
commented
May 7, 2024
| @@ -23,5 +23,5 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency 'rake', '~> 10.0' | |||
| spec.add_development_dependency 'rubocop', '~> 0.49' | |||
|
|
|||
| spec.add_dependency 'railties', '>= 5' | |||
| spec.add_dependency 'railties', '>= 7.2' | |||
There was a problem hiding this comment.
Need to figure out a better way to do this so we can point to it, 7.2.0.alpha is < 7.2.
There was a problem hiding this comment.
Reverting for now so I can point to this to run tests locally.
There was a problem hiding this comment.
Added a TODO, pointing payaus to this branch for now, once 7.2 is out need to merge this + point payaus to master.
There was a problem hiding this comment.
7-2-stable is pretty stable now, I think we can lock this in.
There was a problem hiding this comment.
We can merge this if we want but need to be careful not to delete the branch cause payaus points to this. Might be safer to just leave as is though.
joshuay03
force-pushed
the
support-rails-7-2
branch
2 times, most recently
from
75f3f86 to
ded9a02
Compare
joshuay03
force-pushed
the
support-rails-7-2
branch
from
ded9a02 to
4a2dde8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/TandaHQ/payaus/pull/28824#issuecomment-2097290905
Note that despite these changes, none of these commands work like methods anymore. E.g.
However I doubt the second approach is used by anyone so going with this for now.