Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(orm): add materialization to SELECT CTE statements #1

Open
wants to merge 1 commit into
base: v10
Choose a base branch
from
Open

feat(orm): add materialization to SELECT CTE statements #1

wants to merge 1 commit into from

Conversation

maximerety
Copy link
Member

For emergency situations where we would want to force CTE materialization:

func (q *Query) With(name string, subq *Query) *Query                // WITH "name" AS (...)
func (q *Query) WithMaterialized(name string, subq *Query) *Query    // WITH "name" AS MATERIALIZED (...)
func (q *Query) WithNotMaterialized(name string, subq *Query) *Query // WITH "name" AS NOT MATERIALIZED (...)

@maximerety
feat(orm): add materialization to SELECT CTE statements
80a9806 
For emergency situations where we would want to force CTE materialization:

```go
func (q *Query) With(name string, subq *Query) *Query                // WITH "name" AS (...)
func (q *Query) WithMaterialized(name string, subq *Query) *Query    // WITH "name" AS MATERIALIZED (...)
func (q *Query) WithNotMaterialized(name string, subq *Query) *Query // WITH "name" AS NOT MATERIALIZED (...)
```
@mlevieux
Copy link

LGTM 👍
Thought it would need more changes than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximerety @mlevieux