Fixed type error in chrome content_script mitro-co#124

TasukuUno · Jul 2, 2015 · 1fbd9f5 · 1fbd9f5
1 parent ae43f83
commit 1fbd9f5
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/browser-ext/login/chrome/helpers.js b/browser-ext/login/chrome/helpers.js
@@ -24,7 +24,8 @@
  * *****************************************************************************
  */
 
-var _CHROME_VERSION = parseInt(navigator.userAgent.match(/Chrom(e|ium)\/([0-9]+)\./)[2], 10);
+var _CHROME_VERSION = navigator.userAgent.match(/Chrom(e|ium)\/([0-9]+)\./);
+_CHROME_VERSION = _CHROME_VERSION && parseInt(_CHROME_VERSION[2], 10);
 
 var LAST_AUTOCOMPLETE_COMPLIANT_CHROME_VERSION = 33;
 
@@ -99,7 +100,7 @@ function ContentHelper() {
 
     this.preventAutoFill = function($passwordField, $form) {
         $form.attr('autocomplete', 'off');
-        if (_CHROME_VERSION > LAST_AUTOCOMPLETE_COMPLIANT_CHROME_VERSION) {
+        if (_CHROME_VERSION && _CHROME_VERSION > LAST_AUTOCOMPLETE_COMPLIANT_CHROME_VERSION) {
             console.log('using extreme measures to prevent browser form saving');
             var newInput = document.createElement('input');
             newInput.setAttribute('type', 'password');