Skip to content

Commit

Permalink
fix: fixed an issue with new icon url for roles
Browse files Browse the repository at this point in the history
  • Loading branch information
TeKrop committed Oct 25, 2023
1 parent c0dd1cb commit 5d9da0a
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 8 deletions.
2 changes: 1 addition & 1 deletion app/parsers/roles_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def parse_data(self) -> list[dict]:
).find("blz-feature-carousel-section", recursive=False)

roles_icons = [
role_icon_div.find("blz-image")["src:min-plus"]
role_icon_div.find("blz-image")["src"]
for role_icon_div in roles_container.find("blz-tab-controls").find_all(
"blz-tab-control",
)
Expand Down
16 changes: 12 additions & 4 deletions tests/fixtures/html/home.html

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions tests/fixtures/json/roles.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@
{
"key": "tank",
"name": "Tank",
"icon": "https://blz-contentstack-images.akamaized.net/v3/assets/blt9c12f249ac15c7ec/blt0f8b4fa502f0ea53/62ea8957ed429710b3d9b0b0/Tank.svg",
"icon": "https://blz-contentstack-images.akamaized.net/v3/assets/blt2477dcaf4ebd440c/bltf0889daa1ef606db/6504cff74d2a764cb7973991/Tank.svg?format=webply&quality=90",
"description": "Tank heroes soak up damage and shatter fortified positions, like closely grouped enemies and narrow chokepoints. If you’re a tank, you lead the charge."
},
{
"key": "damage",
"name": "Damage",
"icon": "https://blz-contentstack-images.akamaized.net/v3/assets/blt9c12f249ac15c7ec/bltc1d840ba007f88a8/62ea89572fdd1011027e605d/Damage.svg",
"icon": "https://blz-contentstack-images.akamaized.net/v3/assets/blt2477dcaf4ebd440c/blt05d482c88096959a/6504cff7d9caa1285f64b6bd/Damage.svg?format=webply&quality=90",
"description": "Damage heroes seek out, engage, and obliterate the enemy with wide-ranging tools, abilities, and play styles. Fearsome but fragile, these heroes require backup to survive."
},
{
"key": "support",
"name": "Support",
"icon": "https://blz-contentstack-images.akamaized.net/v3/assets/blt9c12f249ac15c7ec/blt66cec9a29cd34e3d/62ea8957c87999116c02c674/Support.svg",
"icon": "https://blz-contentstack-images.akamaized.net/v3/assets/blt2477dcaf4ebd440c/blt3ccd5df488163b33/6504cff7fc2ae4d7c50445c4/Support.svg?format=webply&quality=90",
"description": "Support heroes empower their allies by healing, shielding, boosting damage, and disabling foes. As a support, you’re the backbone of your team’s survival."
}
]

0 comments on commit 5d9da0a

Please sign in to comment.