fixed issue at start-up with search data retrieval (#223)

TeKrop · Dec 15, 2024 · f21bbf0 · f21bbf0
1 parent 62c77bd
commit f21bbf0
Show file tree

Hide file tree

Showing 55 changed files with 237 additions and 202 deletions.
diff --git a/app/players/commands/update_search_data_cache.py b/app/players/commands/update_search_data_cache.py
@@ -67,12 +67,18 @@ def transform_search_data(
     search_data: dict, data_type: SearchDataType
 ) -> dict[str, str]:
     def get_data_type_value(data_value: dict) -> str:
-        match data_type:
-            case SearchDataType.PORTRAIT | SearchDataType.NAMECARD:
-                return data_value["icon"]
-
-            case SearchDataType.TITLE:
-                return data_value["name"]["en_US"]
+        try:
+            match data_type:
+                case SearchDataType.PORTRAIT | SearchDataType.NAMECARD:
+                    return data_value["icon"]
+
+                case SearchDataType.TITLE:
+                    return data_value["name"]
+        except (KeyError, TypeError):
+            error_message = f"Empty value for {data_type} in search data"
+            logger.exception(error_message)
+            send_discord_webhook_message(error_message)
+            return ""
 
     return {
         data_key: get_data_type_value(data_value)

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [project]
 name = "overfast-api"
-version = "3.8.0"
+version = "3.8.1"
 description = "Overwatch API giving data about heroes, maps, and players statistics."
 license = {file = "LICENSE"}
 authors = [

diff --git a/tests/fixtures/html/heroes.html b/tests/fixtures/html/heroes.html
diff --git a/tests/fixtures/html/heroes/ana.html b/tests/fixtures/html/heroes/ana.html
diff --git a/tests/fixtures/html/heroes/ashe.html b/tests/fixtures/html/heroes/ashe.html
diff --git a/tests/fixtures/html/heroes/baptiste.html b/tests/fixtures/html/heroes/baptiste.html
diff --git a/tests/fixtures/html/heroes/bastion.html b/tests/fixtures/html/heroes/bastion.html
diff --git a/tests/fixtures/html/heroes/brigitte.html b/tests/fixtures/html/heroes/brigitte.html
diff --git a/tests/fixtures/html/heroes/cassidy.html b/tests/fixtures/html/heroes/cassidy.html
diff --git a/tests/fixtures/html/heroes/doomfist.html b/tests/fixtures/html/heroes/doomfist.html
diff --git a/tests/fixtures/html/heroes/dva.html b/tests/fixtures/html/heroes/dva.html
diff --git a/tests/fixtures/html/heroes/echo.html b/tests/fixtures/html/heroes/echo.html
diff --git a/tests/fixtures/html/heroes/genji.html b/tests/fixtures/html/heroes/genji.html
diff --git a/tests/fixtures/html/heroes/hanzo.html b/tests/fixtures/html/heroes/hanzo.html
diff --git a/tests/fixtures/html/heroes/hazard.html b/tests/fixtures/html/heroes/hazard.html
diff --git a/tests/fixtures/html/heroes/illari.html b/tests/fixtures/html/heroes/illari.html
diff --git a/tests/fixtures/html/heroes/junker-queen.html b/tests/fixtures/html/heroes/junker-queen.html
diff --git a/tests/fixtures/html/heroes/junkrat.html b/tests/fixtures/html/heroes/junkrat.html
diff --git a/tests/fixtures/html/heroes/juno.html b/tests/fixtures/html/heroes/juno.html
diff --git a/tests/fixtures/html/heroes/kiriko.html b/tests/fixtures/html/heroes/kiriko.html
diff --git a/tests/fixtures/html/heroes/lifeweaver.html b/tests/fixtures/html/heroes/lifeweaver.html
diff --git a/tests/fixtures/html/heroes/lucio.html b/tests/fixtures/html/heroes/lucio.html
diff --git a/tests/fixtures/html/heroes/mauga.html b/tests/fixtures/html/heroes/mauga.html
diff --git a/tests/fixtures/html/heroes/mei.html b/tests/fixtures/html/heroes/mei.html
diff --git a/tests/fixtures/html/heroes/mercy.html b/tests/fixtures/html/heroes/mercy.html
diff --git a/tests/fixtures/html/heroes/moira.html b/tests/fixtures/html/heroes/moira.html
diff --git a/tests/fixtures/html/heroes/orisa.html b/tests/fixtures/html/heroes/orisa.html
diff --git a/tests/fixtures/html/heroes/pharah.html b/tests/fixtures/html/heroes/pharah.html
diff --git a/tests/fixtures/html/heroes/ramattra.html b/tests/fixtures/html/heroes/ramattra.html
diff --git a/tests/fixtures/html/heroes/reaper.html b/tests/fixtures/html/heroes/reaper.html
diff --git a/tests/fixtures/html/heroes/reinhardt.html b/tests/fixtures/html/heroes/reinhardt.html
diff --git a/tests/fixtures/html/heroes/roadhog.html b/tests/fixtures/html/heroes/roadhog.html
diff --git a/tests/fixtures/html/heroes/sigma.html b/tests/fixtures/html/heroes/sigma.html
diff --git a/tests/fixtures/html/heroes/sojourn.html b/tests/fixtures/html/heroes/sojourn.html
diff --git a/tests/fixtures/html/heroes/soldier-76.html b/tests/fixtures/html/heroes/soldier-76.html
diff --git a/tests/fixtures/html/heroes/sombra.html b/tests/fixtures/html/heroes/sombra.html
diff --git a/tests/fixtures/html/heroes/symmetra.html b/tests/fixtures/html/heroes/symmetra.html
diff --git a/tests/fixtures/html/heroes/torbjorn.html b/tests/fixtures/html/heroes/torbjorn.html
diff --git a/tests/fixtures/html/heroes/tracer.html b/tests/fixtures/html/heroes/tracer.html
diff --git a/tests/fixtures/html/heroes/venture.html b/tests/fixtures/html/heroes/venture.html
diff --git a/tests/fixtures/html/heroes/widowmaker.html b/tests/fixtures/html/heroes/widowmaker.html
diff --git a/tests/fixtures/html/heroes/winston.html b/tests/fixtures/html/heroes/winston.html
diff --git a/tests/fixtures/html/heroes/wrecking-ball.html b/tests/fixtures/html/heroes/wrecking-ball.html
diff --git a/tests/fixtures/html/heroes/zarya.html b/tests/fixtures/html/heroes/zarya.html
diff --git a/tests/fixtures/html/heroes/zenyatta.html b/tests/fixtures/html/heroes/zenyatta.html
diff --git a/tests/fixtures/html/home.html b/tests/fixtures/html/home.html
diff --git a/tests/fixtures/html/players/JohnV1-1190.html b/tests/fixtures/html/players/JohnV1-1190.html
diff --git a/tests/fixtures/html/players/KIRIKO-12460.html b/tests/fixtures/html/players/KIRIKO-12460.html
diff --git a/tests/fixtures/html/players/KIRIKO-21253.html b/tests/fixtures/html/players/KIRIKO-21253.html
diff --git a/tests/fixtures/html/players/TeKrop-2217.html b/tests/fixtures/html/players/TeKrop-2217.html
diff --git a/tests/fixtures/html/players/Unknown-1234.html b/tests/fixtures/html/players/Unknown-1234.html
diff --git a/tests/fixtures/html/search.html b/tests/fixtures/html/search.html
diff --git a/tests/fixtures/json/search_players_blizzard_result.json b/tests/fixtures/json/search_players_blizzard_result.json
@@ -30,14 +30,14 @@
         "url": "d67b87a1fe23caffbca9%7Ce071d6c2df64c91dc7ad8f0eb73d5d05"
     },
     {
-        "battleTag": "KIRIKO#21253",
+        "battleTag": "KIRIKO#12460",
         "frame": "0x0250000000000918",
-        "isPublic": false,
-        "lastUpdated": 1676730323,
-        "namecard": "0x0000000000000000",
-        "portrait": "0x0250000000004D59",
-        "title": "0x0000000000000000",
-        "url": "d67b87a1fe23caffbca9%7Ce071d6c2df64c91dc7ad8f0eb73d5d05"
+        "isPublic": true,
+        "lastUpdated": 1734242338,
+        "namecard": "0x02500000000066FF",
+        "portrait": "0x0250000000007B7D",
+        "title": "0x0250000000006311",
+        "url": "d9779ea3985ed6fcbba421a0%7Cbc8b49f152a4ff7848f37d6df5ec5106"
     },
     {
         "battleTag": "Player#1112937",

diff --git a/tests/helpers.py b/tests/helpers.py
@@ -24,7 +24,7 @@ def read_json_file(filepath: str) -> dict | list | None:
 
 # List of players used for testing
 players_ids = [
-    "KIRIKO-21253",  # Profile with rank on only two roles
+    "KIRIKO-12460",  # Console player
     "TeKrop-2217",  # Classic profile
     "JohnV1-1190",  # Player without any title ingame
 ]

diff --git a/uv.lock b/uv.lock