-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker) : fixed app healthcheck issue #131
Conversation
Reviewer's Guide by SourceryThis pull request addresses issue #130 by fixing the healthcheck configuration in the Docker setup, ensuring that containers can properly run by modifying the healthcheck command in the File-Level Changes
Tips
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TeKrop - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -12,7 +11,7 @@ services: | |||
redis: | |||
condition: service_healthy | |||
healthcheck: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Change in healthcheck URL and wget options
The change from 'localhost' to '0.0.0.0' and the addition of '--spider --quiet' options in wget might have been made for specific reasons. Can you confirm if this change was tested in all environments to ensure it behaves as expected?
Fixed #130 healthcheck issue preventing containers from properly running
Summary by Sourcery
This pull request addresses a healthcheck issue in the Docker configuration that was preventing containers from running properly. The healthcheck command was updated to ensure proper functionality.