Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker) : fixed app healthcheck issue #131

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Jun 9, 2024

Fixed #130 healthcheck issue preventing containers from properly running

Summary by Sourcery

This pull request addresses a healthcheck issue in the Docker configuration that was preventing containers from running properly. The healthcheck command was updated to ensure proper functionality.

  • Bug Fixes:
    • Fixed healthcheck issue in docker-compose.yml by updating the healthcheck command to use 'wget --spider --quiet http://0.0.0.0:8080'.

@TeKrop TeKrop added the bug Something isn't working label Jun 9, 2024
@TeKrop TeKrop self-assigned this Jun 9, 2024
@TeKrop TeKrop linked an issue Jun 9, 2024 that may be closed by this pull request
Copy link
Contributor

sourcery-ai bot commented Jun 9, 2024

Reviewer's Guide by Sourcery

This pull request addresses issue #130 by fixing the healthcheck configuration in the Docker setup, ensuring that containers can properly run by modifying the healthcheck command in the docker-compose.yml file.

File-Level Changes

Files Changes
docker-compose.yml Updated Docker Compose version and modified the healthcheck command to ensure proper container operation.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

sonarqubecloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -12,7 +11,7 @@ services:
redis:
condition: service_healthy
healthcheck:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Change in healthcheck URL and wget options

The change from 'localhost' to '0.0.0.0' and the addition of '--spider --quiet' options in wget might have been made for specific reasons. Can you confirm if this change was tested in all environments to ensure it behaves as expected?

@TeKrop TeKrop merged commit 2603bb7 into main Jun 9, 2024
3 checks passed
@TeKrop TeKrop deleted the 130-error-while-trying-to-start-overfast-api branch June 9, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while trying to start overfast-api
1 participant