Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: now building ngx_http_redis_module.so on nginx image build #137

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Jun 12, 2024

Instead of using already compiled ngx_http_redis_module.so file with nginx container, this PR aims to build the module on image build.

Several benefits :

  • No static module in codebase anymore
  • Should fix running issues on ARM-based machines (Error while trying to start overfast-api #130 )
  • Allows to easily update nginx update, as long as the lib is compatible (not maintained since a long time)

Summary by Sourcery

This pull request modifies the nginx image build process to compile the ngx_http_redis_module.so module during the build, instead of using a pre-compiled version. This change removes the static module from the codebase, resolves issues on ARM-based machines, and facilitates easier nginx updates as long as the library remains compatible.

  • New Features:
    • Build ngx_http_redis_module.so during the nginx image build process.
  • Bug Fixes:
    • Fixed running issues on ARM-based machines by building ngx_http_redis_module.so during image build.
  • Enhancements:
    • Replaced static ngx_http_redis_module.so file with a build process during image creation.

@TeKrop TeKrop added the enhancement New feature or request label Jun 12, 2024
@TeKrop TeKrop self-assigned this Jun 12, 2024
Copy link
Contributor

sourcery-ai bot commented Jun 12, 2024

Reviewer's Guide by Sourcery

This pull request modifies the nginx image build process to compile the ngx_http_redis_module.so module during the image build instead of using a precompiled version. This change aims to remove the static module from the codebase, improve compatibility with ARM-based machines, and facilitate easier nginx updates.

File-Level Changes

Files Changes
docker-compose.yml Modified the healthcheck command to improve its efficiency and reliability.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

docker-compose.yml Show resolved Hide resolved
@TeKrop TeKrop merged commit 037fc09 into main Jun 12, 2024
3 checks passed
@TeKrop TeKrop deleted the feature/ngx-http-redis-so-on-build branch June 12, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant