Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added hazard hero in list #217

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat: added hazard hero in list #217

merged 1 commit into from
Nov 20, 2024

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Nov 20, 2024

Added support for upcoming Hazard hero

Summary by Sourcery

Add support for the upcoming Hazard hero and update the project version to 3.6.0. Include a condition in tests to skip execution if hero HTML data is not available.

New Features:

  • Add support for the upcoming Hazard hero.

Tests:

  • Add a condition to skip tests if hero HTML data is not available.

Chores:

  • Update project version to 3.6.0 in pyproject.toml.

@TeKrop TeKrop added the enhancement New feature or request label Nov 20, 2024
@TeKrop TeKrop self-assigned this Nov 20, 2024
Copy link
Contributor

sourcery-ai bot commented Nov 20, 2024

Reviewer's Guide by Sourcery

This PR adds support for the upcoming Hazard hero by updating the test suite to handle missing hero data and bumping the version number. The changes are minimal and focused on test improvements and version management.

Version update in pyproject.toml

stateDiagram-v2
    [*] --> Version_3_5_1
    Version_3_5_1 --> Version_3_6_0 : Update version
    Version_3_6_0 --> [*]
Loading

File-Level Changes

Change Details Files
Added a skip condition for tests when hero HTML data is not available
  • Added a conditional check to skip the test if hero HTML data is not present
  • Prevents test failures when testing new heroes without complete data
tests/heroes/test_hero_routes.py
Bumped application version for new hero release
  • Incremented version from 3.5.1 to 3.6.0
pyproject.toml
Updated heroes data file
  • Modified heroes.csv to include new hero information
app/heroes/data/heroes.csv

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more detailed PR description explaining what aspects of the Hazard hero are being added and any related changes needed. This will help reviewers better understand the scope of the changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

tests/heroes/test_hero_routes.py Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 20, 2024

@TeKrop TeKrop merged commit 732e771 into main Nov 20, 2024
3 checks passed
@TeKrop TeKrop deleted the feature/add-hazard branch November 20, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant