-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added hazard hero in list #217
Conversation
Reviewer's Guide by SourceryThis PR adds support for the upcoming Hazard hero by updating the test suite to handle missing hero data and bumping the version number. The changes are minimal and focused on test improvements and version management. Version update in pyproject.tomlstateDiagram-v2
[*] --> Version_3_5_1
Version_3_5_1 --> Version_3_6_0 : Update version
Version_3_6_0 --> [*]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TeKrop - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a more detailed PR description explaining what aspects of the Hazard hero are being added and any related changes needed. This will help reviewers better understand the scope of the changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Quality Gate passedIssues Measures |
Added support for upcoming Hazard hero
Summary by Sourcery
Add support for the upcoming Hazard hero and update the project version to 3.6.0. Include a condition in tests to skip execution if hero HTML data is not available.
New Features:
Tests:
Chores: