-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for TTL in response headers #219
Conversation
Reviewer's Guide by SourceryThis PR implements TTL support in response headers by switching from nginx to OpenResty and adding TTL headers to API responses. The implementation involves both infrastructure changes (Docker/nginx) and application code modifications to expose cache TTL values. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TeKrop - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding documentation about the OpenResty/nginx configuration structure since nginx.conf was removed
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add support for TTL in response headers to indicate cache duration and refactor the Dockerfile to use OpenResty instead of Nginx for enhanced Lua script integration.
New Features:
Enhancements:
Build:
Documentation: