fix: using entire btag with encoded number sign for players search

[TeKrop]

If we don't specify the entire battletag to Blizzard when searching for players, sometimes players won't be in search results even if their profile are public. It happens a lot for battletag containing very common nicknames : Arthur, Ace, etc.
The reason on Blizzard side is unknown as there isn't any obvious pagination and number of results differs between different nicknames.

When we specify the entire battletag, the profile can properly be found as expected, this is what this PR is fixing.

Summary by Sourcery

Use the entire BattleTag, including the number sign, when searching for players to ensure consistent results.

Bug Fixes:

• Fixed an issue where players with common nicknames were not appearing in search results when searching by name only.

Enhancements:

• Updated player search to use encoded number signs (%23) in place of dashes (-) in BattleTags.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes an issue where players with common nicknames were not appearing in search results. The issue was caused by not specifying the full battletag when searching. This PR fixes the issue by replacing the dash in the battletag with an encoded number sign (#) before sending the search request to Blizzard.

Sequence diagram for player search with encoded battletag

sequenceDiagram
    participant Client
    participant API
    participant Blizzard

    Client->>API: Search player (battletag)
    Note over API: Replace '-' with '%23'
    API->>Blizzard: Search with encoded battletag
    Blizzard-->>API: Return player data
    API-->>Client: Return search results

Loading

File-Level Changes

Change	Details	Files
Use the entire battletag with encoded number sign for player search	Replace the dash in the player ID with an encoded number sign '%23' before constructing the Blizzard URL. Use the modified player ID when searching for players on Blizzard's servers to ensure the full battletag is used in the search query.	app/players/parsers/search_data_parser.py
Version bump	Increment the version number from 3.8.1 to 3.8.2 in the project's configuration file to reflect the changes made in this release.	pyproject.toml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sourcery-ai]

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}