fix: fixed support for champion rank (ultimate) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request updates the CompetitiveDivision enum to reflect a change in terminology from 'Champion' to 'Ultimate' as used on the Overwatch 2 page. It also updates a test case to align with this change, ensuring that the system correctly recognizes and handles the new 'Ultimate' rank.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that all parts of the application that rely on the CompetitiveDivision enum are updated to handle the 'Ultimate' value correctly. This includes database entries, API responses, and any conditional logic that may have used the 'Champion' value.
- Consider adding a brief comment in the code next to the 'ULTIMATE' enum value to document the reason for this change, especially since it is driven by an external source's terminology update. This can help future maintainers understand the context behind this decision.
- Review the application's user-facing components to ensure that any references to the 'Champion' rank are updated to 'Ultimate' to maintain consistency with the terminology used in Overwatch 2.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, new "Champion" rank on OW2 is named "Ultimate" on their page 🤡