Skip to content

Commit

Permalink
#54 add todos
Browse files Browse the repository at this point in the history
  • Loading branch information
c71n93 committed Feb 19, 2024
1 parent 766e5c3 commit ab749c9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/ChaiVM/utils/instr2Raw.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ static uint8_t operation2opcode(Operation operation) {
return (uint8_t)operation;
}

// @todo #54:60min add template parameter by format and refactor naming
chai::bytecode_t instr2Raw(Operation op, RegisterId r1, RegisterId r2) {
return (operation2opcode(op)) | (r1 << 8) | (r2 << 16);
}
Expand Down
1 change: 1 addition & 0 deletions test/ChaiVM/interpreter/executor-test-fixture.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ class ExecutorTest : public ::testing::Test {
return loadN(op);
}

// @todo #54:60min do something to add this functionality to load Immediate
void loadWithConst(chai::interpreter::Operation op, int64_t data);

void loadWithConst(chai::interpreter::Operation op, double data);
Expand Down

0 comments on commit ab749c9

Please sign in to comment.