Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 도토리 다중 음악 신청 방지 #251

Merged
merged 3 commits into from
Apr 24, 2024
Merged

🔀 도토리 다중 음악 신청 방지 #251

merged 3 commits into from
Apr 24, 2024

Conversation

Ethen1264
Copy link
Contributor

🔍 개요

  • 도토리 음악 신청이 한 사람이 하나 이상을 신청 할 수 있는 문제가 있었습니다.
  • 음악 신청 버튼 스타일 변경

📃 작업사항

image
스크린샷 2024-04-23 오후 5 29 01

🔀 변경로직

  • submit 버튼의 동작이 success일 때 0.3초의 디바운스를 걸어 방지 하였습니다.
  • input value가 정규식에 맞을 때 버튼의 스타일이 활성화 되게 수정하였습니다.

@Ethen1264 Ethen1264 added 🐞 Type: Bug 버그 발생 1️⃣ Priority: High 우선순위: 상 🎨 Type: Publishing 퍼블리싱 labels Apr 23, 2024
@Ethen1264 Ethen1264 self-assigned this Apr 23, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dotori-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 0:10am

likegitman
likegitman reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@likegitman likegitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실수 하신 것 같아 말씀드려요! Dotori의 커밋 컨벤션이 있으니 컨벤션 따라주세요.

@Ethen1264 Ethen1264 merged commit 9be7edf into develop Apr 24, 2024
3 checks passed
@mini-aron mini-aron mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeoJumee SeoJumee SeoJumee approved these changes

@likegitman likegitman likegitman approved these changes

@mini-aron mini-aron mini-aron approved these changes

@apnalkkamkkamhanjoon apnalkkamkkamhanjoon apnalkkamkkamhanjoon approved these changes

@kangkong0805 kangkong0805 Awaiting requested review from kangkong0805 kangkong0805 is a code owner

@HWANBINYOO HWANBINYOO Awaiting requested review from HWANBINYOO HWANBINYOO is a code owner

@wjdalsths wjdalsths Awaiting requested review from wjdalsths wjdalsths is a code owner

Assignees

@Ethen1264 Ethen1264

Labels
1️⃣ Priority: High 우선순위: 상 🐞 Type: Bug 버그 발생 🎨 Type: Publishing 퍼블리싱
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ethen1264 @SeoJumee @likegitman @mini-aron @apnalkkamkkamhanjoon