Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ ๋‚˜์ด์Šค meal api ํ†ต์‹  ์ˆ˜์ • #262

Merged
merged 3 commits into from
Jun 7, 2024
Merged

๐Ÿ”€ ๋‚˜์ด์Šค meal api ํ†ต์‹  ์ˆ˜์ • #262

merged 3 commits into from
Jun 7, 2024

Conversation

Ethen1264
Copy link
Contributor

๐Ÿ” ๊ฐœ์š”

๊ธฐ์กด ๋‚ ์งœ๋ฅผ ๋ณ€๊ฒฝํ•˜๋Š” ๊ฒƒ์ด ์•„๋‹Œ ์กฐ์‹ ์ค‘์‹ ์„์‹์„ ๋ณ€๊ฒฝํ•ด๋„ api๊ฐ€ ํ˜ธ์ถœ๋˜๋Š” ๋ฌธ์ œ๊ฐ€ ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ƒ ์ž‘์—…์‚ฌํ•ญ

image

  • api๋ฅผ ํ˜ธ์ถœํ•˜์—ฌ state์— ์ €์žฅ ํ›„ useEffect๋กœ ์กฐ์‹, ์ค‘์‹, ์„์‹์ด ์•„๋‹Œ ์š”์ผ์ด ๋ฐ”๋€”๋•Œ๋งŒ api๋ฅผ ํ˜ธ์ถœํ•˜๊ฒŒ ๋ณ€๊ฒฝ ํ–ˆ์Šต๋‹ˆ๋‹ค.

@Ethen1264 Ethen1264 added ๐Ÿž Type: Bug ๋ฒ„๊ทธ ๋ฐœ์ƒ ๐Ÿ“ฌ Type: API ์„œ๋ฒ„ API ํ†ต์‹  ๐Ÿช› Type: Performance ์„ฑ๋Šฅ ๊ฐœ์„  labels Jun 6, 2024
@Ethen1264 Ethen1264 self-assigned this Jun 6, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
dotori-v2 โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jun 6, 2024 4:51pm

@Ethen1264 Ethen1264 changed the title ๐Ÿ”€ ๋‚˜์ด์Šค meal api ํ†ต์‹ ์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. ๐Ÿ”€ ๋‚˜์ด์Šค meal api ํ†ต์‹  ์ˆ˜์ • Jun 6, 2024
@Ethen1264 Ethen1264 merged commit d3a0799 into develop Jun 7, 2024
3 checks passed
@Ethen1264 Ethen1264 mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeoJumee SeoJumee SeoJumee approved these changes

@likegitman likegitman likegitman approved these changes

@mini-aron mini-aron mini-aron approved these changes

@kangkong0805 kangkong0805 Awaiting requested review from kangkong0805 kangkong0805 is a code owner

@HWANBINYOO HWANBINYOO Awaiting requested review from HWANBINYOO HWANBINYOO is a code owner

@wjdalsths wjdalsths Awaiting requested review from wjdalsths wjdalsths is a code owner

@apnalkkamkkamhanjoon apnalkkamkkamhanjoon Awaiting requested review from apnalkkamkkamhanjoon apnalkkamkkamhanjoon is a code owner

Assignees

@Ethen1264 Ethen1264

Labels
๐Ÿ“ฌ Type: API ์„œ๋ฒ„ API ํ†ต์‹  ๐Ÿž Type: Bug ๋ฒ„๊ทธ ๋ฐœ์ƒ ๐Ÿช› Type: Performance ์„ฑ๋Šฅ ๊ฐœ์„ 
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ethen1264 @SeoJumee @likegitman @mini-aron