๐Style(#246): Spinner ์ ์ฉ #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIY00N2
added
์คํ์ผ
1 task
sscoderati
approved these changes
Nov 24, 2023
| @@ -150,7 +150,7 @@ const SteadyDetailPage = ({ params }: { params: PageParams }) => { | |||
| </div> | |||
| } | |||
| > | |||
| <Suspense fallback={<Spinner size="medium" />}> | |||
| <Suspense fallback={<Spinner size="large" />}> | |||
There was a problem hiding this comment.
Large ์คํผ๋๊ฐ ๋๋์ด ์ฐ์์๋ฅผ ์ฐพ์๊ตฐ์.. ๊ฐ๊ฒฉ..
| <div className={cn("mb-30")}>{children}</div> | ||
| <div className="pb-30">{children}</div> |
There was a problem hiding this comment.
์ค ์ด๋ค ์ฐจ์ด๊ฐ ์์๋์?
Comment on lines
-10
to
+11
| queryKey: ["userProfile", userId], | ||
| queryKey: getUserProfileKey(userId), |
src/constants/queryKeys.ts
Outdated
| @@ -56,3 +56,6 @@ export const StacksKey = ["stacks"]; | |||
|
|
|||
| // Review | |||
| export const MyReviewKey = ["myreview"]; | |||
|
|
|||
| // User | |||
| export const getUserProfileKey = (userId: number) => ["userProfile", userId]; | |||
There was a problem hiding this comment.
์ข์ ๊ธฐ๋ฅ์ ์ ๊ณตํ์ง๋ง ํจ์๋ช ์ด data fetching ๊ณ์ด์ ํจ์๋ค๊ณผ ๊ฐ์์ ํผ๋์ด ์์ ์ ์๊ฒ ๋ค์ ใ ใ
There was a problem hiding this comment.
๋ง์์ ใ ใ ๊ทธ๋์ ์ ๋ฏธ์ฌ๋ฅผ Key๋ก ํต์ผํ์ต๋๋ค!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ ๊ตฌํ ์ฌํญ
_2023_11_23_23_44_56_145.mp4
๐ง ํน์ด ์ฌํญ
๐จ๊ด๋ จ ์ด์
close #246